* [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-07 15:24 ` Grygorii Strashko
0 siblings, 0 replies; 6+ messages in thread
From: Grygorii Strashko @ 2014-04-07 15:24 UTC (permalink / raw)
To: linux-arm-kernel
I2C nodes should always have #address-cells and #size-cells defined.
Hence, ensure that all i2cX nodes have #address-cells and #size-cells
properties defined.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
arch/arm/boot/dts/keystone.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 90823eb..f730392 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -115,6 +115,8 @@
clock-frequency = <100000>;
clocks = <&clki2c>;
interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
i2c2: i2c at 2530800 {
@@ -123,6 +125,8 @@
clock-frequency = <100000>;
clocks = <&clki2c>;
interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
spi0: spi at 21000400 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-07 15:24 ` Grygorii Strashko
0 siblings, 0 replies; 6+ messages in thread
From: Grygorii Strashko @ 2014-04-07 15:24 UTC (permalink / raw)
To: santosh.shilimkar-l0cyMroinI0
Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Grygorii Strashko
I2C nodes should always have #address-cells and #size-cells defined.
Hence, ensure that all i2cX nodes have #address-cells and #size-cells
properties defined.
Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 90823eb..f730392 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -115,6 +115,8 @@
clock-frequency = <100000>;
clocks = <&clki2c>;
interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
i2c2: i2c@2530800 {
@@ -123,6 +125,8 @@
clock-frequency = <100000>;
clocks = <&clki2c>;
interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
spi0: spi@21000400 {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-07 17:50 ` Santosh Shilimkar
0 siblings, 0 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2014-04-07 17:50 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
> I2C nodes should always have #address-cells and #size-cells defined.
> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
> properties defined.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Right. BTW, have you seen some issue without this patch ?
Just curious what prompted you to create this patch and whether
it needs to be sent as fix during rc's.
Regards,
Santosh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-07 17:50 ` Santosh Shilimkar
0 siblings, 0 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2014-04-07 17:50 UTC (permalink / raw)
To: Grygorii Strashko
Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
> I2C nodes should always have #address-cells and #size-cells defined.
> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
> properties defined.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
> ---
Right. BTW, have you seen some issue without this patch ?
Just curious what prompted you to create this patch and whether
it needs to be sent as fix during rc's.
Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-08 9:07 ` Grygorii Strashko
0 siblings, 0 replies; 6+ messages in thread
From: Grygorii Strashko @ 2014-04-08 9:07 UTC (permalink / raw)
To: linux-arm-kernel
On 04/07/2014 08:50 PM, Santosh Shilimkar wrote:
> On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
>> I2C nodes should always have #address-cells and #size-cells defined.
>> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
>> properties defined.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
> Right. BTW, have you seen some issue without this patch ?
> Just curious what prompted you to create this patch and whether
> it needs to be sent as fix during rc's.
I think, it can wait for next. Without this patch warnings will
be produced in case of adding child node to the bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c at 2530800/pca at 20
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c at 2530800/pca at 20
I'll updated patch description and resend.
Regards,
-grygorii
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: keystone: add cell's information to i2c nodes
@ 2014-04-08 9:07 ` Grygorii Strashko
0 siblings, 0 replies; 6+ messages in thread
From: Grygorii Strashko @ 2014-04-08 9:07 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 04/07/2014 08:50 PM, Santosh Shilimkar wrote:
> On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote:
>> I2C nodes should always have #address-cells and #size-cells defined.
>> Hence, ensure that all i2cX nodes have #address-cells and #size-cells
>> properties defined.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
>> ---
> Right. BTW, have you seen some issue without this patch ?
> Just curious what prompted you to create this patch and whether
> it needs to be sent as fix during rc's.
I think, it can wait for next. Without this patch warnings will
be produced in case of adding child node to the bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c@2530800/pca@20
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c@2530800/pca@20
I'll updated patch description and resend.
Regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-08 9:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-07 15:24 [PATCH] ARM: dts: keystone: add cell's information to i2c nodes Grygorii Strashko
2014-04-07 15:24 ` Grygorii Strashko
2014-04-07 17:50 ` Santosh Shilimkar
2014-04-07 17:50 ` Santosh Shilimkar
2014-04-08 9:07 ` Grygorii Strashko
2014-04-08 9:07 ` Grygorii Strashko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.