From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rjw@rjwysocki.net, lenb@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpuidle: sysfs: Export target residency information
Date: Tue, 08 Apr 2014 11:13:16 +0200 [thread overview]
Message-ID: <5343BDAC.70603@linaro.org> (raw)
In-Reply-To: <1395055050-27729-1-git-send-email-daniel.lezcano@linaro.org>
On 03/17/2014 12:17 PM, Daniel Lezcano wrote:
> From userspace, there is no way to know the target residency for each idle
> state. If we want to write tools to measure the accuracy of the idle state
> selection from the governor, we need this info.
>
> As the exit latency is exported through sysfs, exporting the target residency
> in the same place makes sense.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Hi Rafael,
are you willing to take this patch ?
Thanks
-- Daniel
> drivers/cpuidle/sysfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index e918b6d..efe2f17 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -293,6 +293,7 @@ static ssize_t show_state_##_name(struct cpuidle_state *state, \
> }
>
> define_show_state_function(exit_latency)
> +define_show_state_function(target_residency)
> define_show_state_function(power_usage)
> define_show_state_ull_function(usage)
> define_show_state_ull_function(time)
> @@ -304,6 +305,7 @@ define_store_state_ull_function(disable)
> define_one_state_ro(name, show_state_name);
> define_one_state_ro(desc, show_state_desc);
> define_one_state_ro(latency, show_state_exit_latency);
> +define_one_state_ro(residency, show_state_target_residency);
> define_one_state_ro(power, show_state_power_usage);
> define_one_state_ro(usage, show_state_usage);
> define_one_state_ro(time, show_state_time);
> @@ -313,6 +315,7 @@ static struct attribute *cpuidle_state_default_attrs[] = {
> &attr_name.attr,
> &attr_desc.attr,
> &attr_latency.attr,
> + &attr_residency.attr,
> &attr_power.attr,
> &attr_usage.attr,
> &attr_time.attr,
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2014-04-08 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:17 [PATCH] cpuidle: sysfs: Export target residency information Daniel Lezcano
2014-04-08 9:13 ` Daniel Lezcano [this message]
2014-04-08 11:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343BDAC.70603@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.