All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/2] PCI: Refactor pci_is_bridge()
Date: Tue, 8 Apr 2014 17:26:31 +0800	[thread overview]
Message-ID: <5343C0C7.3050806@huawei.com> (raw)
In-Reply-To: <20140404233251.GB15806@google.com>

>> +static inline bool pci_is_bridge(struct pci_dev *dev)
>> +{
>> +	return dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
>> +		dev->hdr_type == PCI_HEADER_TYPE_CARDBUS;
>> +}
> 
> There's no point in adding this unless somebody uses it (but I assume
> you probably meant to use it in acpi_pci_find_companion() as I mentioned).

I will resend a complete patchset soon if you think it make sense.

Thanks!
Yijing.

> 
>>  /**
>>   * pcie_caps_reg - get the PCIe Capabilities Register
>>   * @dev: PCI device
>> -- 
>> 1.7.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


-- 
Thanks!
Yijing


      reply	other threads:[~2014-04-08  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  9:38 [PATCH 2/2] PCI: Refactor pci_is_bridge() Yijing Wang
2014-04-04 23:32 ` Bjorn Helgaas
2014-04-08  9:26   ` Yijing Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5343C0C7.3050806@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.