Re: [PATCH] video: imxfb: Select LCD_CLASS_DEVICE unconditionally

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On 08/04/14 13:08, Alexander Shiyan wrote:
> Tue, 8 Apr 2014 12:58:32 +0300 от Tomi Valkeinen <tomi.valkeinen@ti.com>:
>> Hi,
>>
>> On 20/03/14 08:58, Alexander Shiyan wrote:
>>> FB driver uses lowlevel controls for LCD powering and contrast changing.
>>> Since LCD class cannot be used as an optional feature and should be
>>> compiled for using in the driver, this patch selects LCD_CLASS_DEVICE
>>> symbol for the driver.
>>>
>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>> ---
>>>  drivers/video/fbdev/Kconfig | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>>> index 67409e0..b7cb0af 100644
>>> --- a/drivers/video/fbdev/Kconfig
>>> +++ b/drivers/video/fbdev/Kconfig
>>> @@ -328,6 +328,8 @@ config FB_SA1100
>>>  config FB_IMX
>>>  	tristate "Freescale i.MX1/21/25/27 LCD support"
>>>  	depends on FB && IMX_HAVE_PLATFORM_IMX_FB
>>> +	select BACKLIGHT_LCD_SUPPORT
>>> +	select LCD_CLASS_DEVICE
>>>  	select FB_CFB_FILLRECT
>>>  	select FB_CFB_COPYAREA
>>>  	select FB_CFB_IMAGEBLIT
>>
>> I presume this should go in for 3.15?
> 
> Yes. Otherwise we may have problems with the compiling.

Ok, queuing this for 3.15 fixes.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]