From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WXUkQ-0006yf-JC for mharc-qemu-trivial@gnu.org; Tue, 08 Apr 2014 08:03:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXUkF-0006wQ-FT for qemu-trivial@nongnu.org; Tue, 08 Apr 2014 08:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXUk6-0003sF-EE for qemu-trivial@nongnu.org; Tue, 08 Apr 2014 08:03:15 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:53190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXUk6-0003rR-7o; Tue, 08 Apr 2014 08:03:06 -0400 Received: by mail-pa0-f41.google.com with SMTP id fa1so942172pad.28 for ; Tue, 08 Apr 2014 05:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ltDn5OB3QN2KEnyvLZZQGkQwQ7Ni0Hr9abpeQD9ui0I=; b=beRS/M5uTEZwn72D6GV/S8u9ZTyZ7jWJkUbW6Q5OEQMi1xyrODdeZ9kgFXnUZeIIaw kac+Xy3gtGGqgHqodnLwFsIYugGfMyHX3iZXBU29pkRMCBzzqxuRiz8MVBjWeTwL1lvt RLbCPrMMa/ltwqchnbu2Tv/CeRob8KCYAsXUqratHn0o7Agx6gOTaBWKENTfanEOX8Af jeSBgvw41jf7DOSEk/OtVC3L3LkblHQijzb7hoKl26hpiwxlOQZbJEn946L+kC2egcTs 2Y2iyR0mkHC33TzHnOBPDVY/DkZF5Op1/nRDVWPEGNPF8y+LKA+GwssbPbGcXMQaArCF zyEQ== X-Received: by 10.68.191.138 with SMTP id gy10mr1262682pbc.169.1396958585291; Tue, 08 Apr 2014 05:03:05 -0700 (PDT) Received: from [192.168.1.104] ([124.126.227.121]) by mx.google.com with ESMTPSA id yo9sm9463059pab.16.2014.04.08.05.03.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 05:03:04 -0700 (PDT) Message-ID: <5343E571.60407@gmail.com> Date: Tue, 08 Apr 2014 20:02:57 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Michael Tokarev References: <53337BEB.90305@gmail.com> <87wqfgrp83.fsf@blackfin.pond.sub.org> <5333F6E2.9080202@gmail.com> <53382DDD.8050001@gmail.com> <87fvlylf02.fsf@blackfin.pond.sub.org> <53396545.805@gmail.com> <533969AB.4010505@gmail.com> <53396CE9.9090405@gmail.com> <533E7DD5.3090203@gmail.com> <5340F4FD.7040305@msgid.tls.msk.ru> <53414941.5040908@gmail.com> <5343E4D4.6070305@gmail.com> <5343E516.3020103@gmail.com> In-Reply-To: <5343E516.3020103@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::229 Cc: QEMU Trivial , Peter Maydell , Markus Armbruster , Anthony Liguori , QEMU Developers Subject: [Qemu-trivial] [PATCH trivial 2/3] vl: remove redundant local variable 'res' X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Apr 2014 12:03:24 -0000 In function, if no additional resources to free before quit, commonly, need not use additional local variable 'res' to notice about it. So remove it to simplify code. Signed-off-by: Chen Gang --- vl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 7505002..377f962 100644 --- a/vl.c +++ b/vl.c @@ -1188,18 +1188,16 @@ DeviceState *get_boot_device(uint32_t position) { uint32_t counter = 0; FWBootEntry *i = NULL; - DeviceState *res = NULL; if (!QTAILQ_EMPTY(&fw_boot_order)) { QTAILQ_FOREACH(i, &fw_boot_order, link) { if (counter == position) { - res = i->dev; - break; + return i->dev; } counter++; } } - return res; + return NULL; } /* -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXUkX-00071e-Lr for qemu-devel@nongnu.org; Tue, 08 Apr 2014 08:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXUkO-000464-KA for qemu-devel@nongnu.org; Tue, 08 Apr 2014 08:03:33 -0400 Message-ID: <5343E571.60407@gmail.com> Date: Tue, 08 Apr 2014 20:02:57 +0800 From: Chen Gang MIME-Version: 1.0 References: <53337BEB.90305@gmail.com> <87wqfgrp83.fsf@blackfin.pond.sub.org> <5333F6E2.9080202@gmail.com> <53382DDD.8050001@gmail.com> <87fvlylf02.fsf@blackfin.pond.sub.org> <53396545.805@gmail.com> <533969AB.4010505@gmail.com> <53396CE9.9090405@gmail.com> <533E7DD5.3090203@gmail.com> <5340F4FD.7040305@msgid.tls.msk.ru> <53414941.5040908@gmail.com> <5343E4D4.6070305@gmail.com> <5343E516.3020103@gmail.com> In-Reply-To: <5343E516.3020103@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: QEMU Trivial , Peter Maydell , Markus Armbruster , Anthony Liguori , QEMU Developers In function, if no additional resources to free before quit, commonly, need not use additional local variable 'res' to notice about it. So remove it to simplify code. Signed-off-by: Chen Gang --- vl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 7505002..377f962 100644 --- a/vl.c +++ b/vl.c @@ -1188,18 +1188,16 @@ DeviceState *get_boot_device(uint32_t position) { uint32_t counter = 0; FWBootEntry *i = NULL; - DeviceState *res = NULL; if (!QTAILQ_EMPTY(&fw_boot_order)) { QTAILQ_FOREACH(i, &fw_boot_order, link) { if (counter == position) { - res = i->dev; - break; + return i->dev; } counter++; } } - return res; + return NULL; } /* -- 1.7.9.5