From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH] xen: move PIRQ EOI map fields to arch_domain Date: Tue, 8 Apr 2014 14:16:48 +0200 Message-ID: <5343E8B0.2020505@citrix.com> References: <1396953231-19005-1-git-send-email-roger.pau@citrix.com> <5343FAC302000078000069DC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXUxQ-0005Yc-Ue for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 12:16:53 +0000 In-Reply-To: <5343FAC302000078000069DC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 08/04/14 13:33, Jan Beulich wrote: >>>> On 08.04.14 at 12:33, wrote: >> @@ -354,7 +353,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) >> } >> mfn = page_to_mfn(page); >> >> - if ( cmpxchg(&v->domain->arch.pv_domain.pirq_eoi_map_mfn, >> + if ( cmpxchg(&v->domain->arch.pirq_eoi_map_mfn, > > In order to get here you also need to modify hvm_physdev_op(). This is on top of Mukesh PVH Dom0 v8 series (as stated on the description), which has the following in hvm_physdev_op: static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { switch ( cmd ) { default: if ( !is_pvh_vcpu(current) || !is_hardware_domain(current->domain) ) return -ENOSYS; /* fall through */ case PHYSDEVOP_map_pirq: case PHYSDEVOP_unmap_pirq: case PHYSDEVOP_eoi: case PHYSDEVOP_irq_status_query: case PHYSDEVOP_get_free_pirq: return do_physdev_op(cmd, arg); } } Thus allowing PVH Dom0 to use any PHYSDEVOP_* Roger.