From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [Intel-gfx] [PATCH] drm/i915: support address only i2c-over-aux transactions Date: Tue, 08 Apr 2014 15:09:56 +0200 Message-ID: <5343F524.7020400@vodafone.de> References: <1396859864-25955-1-git-send-email-thierry.reding@gmail.com> <1396863445-30958-1-git-send-email-jani.nikula@intel.com> <87bnwc9ujg.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FF9D6EA10 for ; Tue, 8 Apr 2014 06:10:10 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , Daniel Vetter Cc: Jani Nikula , Intel Graphics Development , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org Am 08.04.2014 15:04, schrieb Alex Deucher: > On Tue, Apr 8, 2014 at 4:03 AM, Daniel Vetter wrote: >> On Tue, Apr 8, 2014 at 8:58 AM, Jani Nikula wrote: >>> Before the conversion to dp aux helpers there was a switch case [1] that >>> ended up in msg_bytes = 3 for address only start/stop messages >>> (MODE_I2C_START or MODE_I2C_STOP bit set [2]). With Alex's series in, >>> but without my patch, we'd send the four byte header but with 0 - 1 = >>> 0xff in txbuf[3]. I'm pretty sure breakage would follow. >>> >>> Thus I'd like to have my patch in before the dp aux helpers use >>> msg->size == 0 for address only messages. >>> >>> Daniel, convinced yet? >> Indeed, I've been blinding. Acked for merging through radeon trees >> together with the other patches as a fixup for 3.15. > Christian, > > Can you pull this into the radeon 3.15 branch as well? Sure, directly before your other patches I would assume. Going to send out the pull request to Dave this evening if nobody objects. Christian. > > Thanks, > > Alex