Re: [Qemu-devel] [PATCH v2 07/12] block/json: Add bdrv_co_get_block_status()

[Max Reitz <mreitz@redhat.com>]

On 07.03.2014 23:55, Max Reitz wrote:
> Implement this function in the same way as raw_bsd does: Acknowledge
> that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID
> and BDRV_BLOCK_DATA and derive the offset directly from the sector
> index) and add BDRV_BLOCK_RAW to the returned value.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   block/json.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)

Ping – Benoît is unsure of BDRV_BLOCK_RAW, therefore he elected not to 
give a reviewed-by for this patch.

The commit introducing BDRV_BLOCK_RAW 
(92bc50a5ad7fbc9a0bd17240eaea5027a100ca79) is signed-off-by Peter, 
reviewed-by Eric and signed-off-by Kevin (as the committer, I suppose). 
Could anyone of you comment on this patch? The question is whether to 
use BDRV_BLOCK_RAW or a recursive call to bdrv_get_block_status() here. 
I mean, I could just replace the BDRV_BLOCK_RAW by a recursive call to 
bdrv_get_block_status() and Benoît would probably approve, but obviously 
that would be cheating.


Max