From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 09/32] drm/exynos: Rename display_op power_on to dpms Date: Fri, 08 Nov 2013 23:09:21 +0100 Message-ID: <5344006.GV5p0AksRE@flatron> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-10-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id DA37CF9F0D for ; Fri, 8 Nov 2013 14:09:21 -0800 (PST) Received: by mail-ee0-f42.google.com with SMTP id c1so1301981eek.29 for ; Fri, 08 Nov 2013 14:09:20 -0800 (PST) In-Reply-To: <1383063198-10526-10-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org On Tuesday 29 of October 2013 12:12:55 Sean Paul wrote: > This patch renames the display_op power_on to dpms to accurately reflect > what the function does. > > The side-effect of this patch is that the new hdmi dpms callback is now > invoked twice in the dpms path. This is safe and will be dealt with when > the exynos_drm shim goes away. > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: > - Changed vidi to dpms as well > > drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 ++-- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 4 ++-- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 8 -------- > drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 8 ++++---- > drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 3 +-- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 -------- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 7 files changed, 10 insertions(+), 27 deletions(-) Patch description fails to mention about removing dummy callbacks from FIMD and ViDi drivers, but that's just a nitpick, so: Reviewed-by: Tomasz Figa Best regards, Tomasz