From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] xen: move PIRQ EOI map fields to arch_domain
Date: Tue, 8 Apr 2014 15:58:14 +0200
Message-ID: <53440076.7080507@citrix.com>
References: <1396953231-19005-1-git-send-email-roger.pau@citrix.com>
	<5343FAC302000078000069DC@nat28.tlf.novell.com>
	<5343E8B0.2020505@citrix.com>
	<53440F640200007800006A4F@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1WXWXb-0002er-4F
	for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 13:58:19 +0000
In-Reply-To: <53440F640200007800006A4F@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 08/04/14 15:01, Jan Beulich wrote:
>>>> On 08.04.14 at 14:16, <roger.pau@citrix.com> wrote:
>> On 08/04/14 13:33, Jan Beulich wrote:
>>>>>> On 08.04.14 at 12:33, <roger.pau@citrix.com> wrote:
>>>> @@ -354,7 +353,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) 
>> arg)
>>>>          }
>>>>          mfn = page_to_mfn(page);
>>>>  
>>>> -        if ( cmpxchg(&v->domain->arch.pv_domain.pirq_eoi_map_mfn,
>>>> +        if ( cmpxchg(&v->domain->arch.pirq_eoi_map_mfn,
>>>
>>> In order to get here you also need to modify hvm_physdev_op().
>>
>> This is on top of Mukesh PVH Dom0 v8 series (as stated on the 
>> description), which has the following in hvm_physdev_op:
>>
>> static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>> {
>>     switch ( cmd )
>>     {
>>     default:
>>         if ( !is_pvh_vcpu(current) || !is_hardware_domain(current->domain) )
>>             return -ENOSYS;
>>         /* fall through */
>>     case PHYSDEVOP_map_pirq:
>>     case PHYSDEVOP_unmap_pirq:
>>     case PHYSDEVOP_eoi:
>>     case PHYSDEVOP_irq_status_query:
>>     case PHYSDEVOP_get_free_pirq:
>>         return do_physdev_op(cmd, arg);
>>     }
>> }
> 
> I don't recall that series to include a revert of a7ca5c40 ("x86/pvh:
> disallow PHYSDEVOP_pirq_eoi_gmfn_v2/v1"), and if it did it would
> be wrong, as then it would have to already include the changes you
> are doing here.

OK, now I see it, Mukesh Dom0 PVH v8 series is based on top of
b3c0519e019de3fcd993913ab48c327daec35115, which is previous to your
commit of a7ca5c40:

https://oss.oracle.com/git/?p=mrathor/xen.git;a=shortlog;h=dom0pvh-v8

Will rebase on top of unstable and post a v2, do you have any other
comments related to the patch that I should fix before posting v2?

Roger.