All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mel Gorman <mgorman@suse.de>, Linux-X86 <x86@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Steven Noonan <steven@uplinklabs.net>,
	Rik van Riel <riel@redhat.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>David Vrabel
	<david.vrabel@citrix.com>
Subject: Re: [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2
Date: Tue, 08 Apr 2014 07:40:29 -0700	[thread overview]
Message-ID: <53440A5D.6050301@zytor.com> (raw)
In-Reply-To: <1396962570-18762-1-git-send-email-mgorman@suse.de>

On 04/08/2014 06:09 AM, Mel Gorman wrote:
> Using unused physical bits is something that will break eventually.
> 
> Changelog since V1
> o Reuse software-bits
> o Use paravirt ops when modifying PTEs in the NUMA helpers
> 
> Aliasing _PAGE_NUMA and _PAGE_PROTNONE had some convenient properties but
> it ultimately gave Xen a headache and pisses almost everybody off that
> looks closely at it. Two discussions on "why this makes sense" is one
> discussion too many so rather than having a third so here is this series.
> This series reuses the PTE bits that are available to the programmer.
> This adds some contraints on how and when automatic NUMA balancing can be
> enabled but it should go away again when Xen stops using _PAGE_IOMAP.
> 
> The series also converts the NUMA helpers to use paravirt-friendly operations
> but it needs a Tested-by from the Xen and powerpc people.
> 

It is proably simpler to just base this patchset on top of David
Vrabel's which actually *does* remove _PAGE_IOMAP.

David, is your patchset going to be pushed in this merge window as expected?

That being said, these bits are precious, and if this ends up being a
case where "only Xen needs another bit" once again then Xen should
expect to get kicked to the curb at a moment's notice.

	-hpa


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mel Gorman <mgorman@suse.de>, Linux-X86 <x86@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Steven Noonan <steven@uplinklabs.net>,
	Rik van Riel <riel@redhat.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Vrabel <david.vrabel@citrix.com>
Subject: Re: [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2
Date: Tue, 08 Apr 2014 07:40:29 -0700	[thread overview]
Message-ID: <53440A5D.6050301@zytor.com> (raw)
In-Reply-To: <1396962570-18762-1-git-send-email-mgorman@suse.de>

On 04/08/2014 06:09 AM, Mel Gorman wrote:
> Using unused physical bits is something that will break eventually.
> 
> Changelog since V1
> o Reuse software-bits
> o Use paravirt ops when modifying PTEs in the NUMA helpers
> 
> Aliasing _PAGE_NUMA and _PAGE_PROTNONE had some convenient properties but
> it ultimately gave Xen a headache and pisses almost everybody off that
> looks closely at it. Two discussions on "why this makes sense" is one
> discussion too many so rather than having a third so here is this series.
> This series reuses the PTE bits that are available to the programmer.
> This adds some contraints on how and when automatic NUMA balancing can be
> enabled but it should go away again when Xen stops using _PAGE_IOMAP.
> 
> The series also converts the NUMA helpers to use paravirt-friendly operations
> but it needs a Tested-by from the Xen and powerpc people.
> 

It is proably simpler to just base this patchset on top of David
Vrabel's which actually *does* remove _PAGE_IOMAP.

David, is your patchset going to be pushed in this merge window as expected?

That being said, these bits are precious, and if this ends up being a
case where "only Xen needs another bit" once again then Xen should
expect to get kicked to the curb at a moment's notice.

	-hpa



  parent reply	other threads:[~2014-04-08 14:46 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 13:09 [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2 Mel Gorman
2014-04-08 13:09 ` Mel Gorman
2014-04-08 13:09 ` [PATCH 1/5] x86: Require x86-64 for automatic NUMA balancing Mel Gorman
2014-04-08 13:09   ` Mel Gorman
2014-04-08 13:09 ` [PATCH 2/5] x86: Define _PAGE_NUMA by reusing software bits on the PMD and PTE levels Mel Gorman
2014-04-08 13:09   ` Mel Gorman
2014-04-08 13:09 ` [PATCH 3/5] mm: Allow FOLL_NUMA on FOLL_FORCE Mel Gorman
2014-04-08 13:09   ` Mel Gorman
2014-04-08 13:09 ` [PATCH 4/5] mm: use paravirt friendly ops for NUMA hinting ptes Mel Gorman
2014-04-08 13:09   ` Mel Gorman
2014-04-08 17:21   ` David Vrabel
2014-04-08 17:21     ` David Vrabel
2014-04-15 10:27   ` David Vrabel
2014-04-15 10:27     ` David Vrabel
2014-04-15 14:44     ` Mel Gorman
2014-04-15 14:44       ` Mel Gorman
2014-04-08 13:09 ` [PATCH 5/5] x86: Allow Xen to enable NUMA_BALANCING Mel Gorman
2014-04-08 13:09   ` Mel Gorman
2014-04-08 14:40 ` H. Peter Anvin [this message]
2014-04-08 14:40   ` [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2 H. Peter Anvin
2014-04-08 15:22   ` Linus Torvalds
2014-04-08 15:22     ` Linus Torvalds
2014-04-08 16:04     ` H. Peter Anvin
2014-04-08 16:04       ` H. Peter Anvin
2014-04-08 16:12     ` Peter Zijlstra
2014-04-08 16:12       ` Peter Zijlstra
2014-04-08 16:46     ` Mel Gorman
2014-04-08 16:46       ` Mel Gorman
2014-04-08 17:01       ` Linus Torvalds
2014-04-08 17:01         ` Linus Torvalds
2014-04-08 18:51         ` Mel Gorman
2014-04-08 18:51           ` Mel Gorman
2014-04-08 18:55           ` Linus Torvalds
2014-04-08 18:55             ` Linus Torvalds
2014-04-08 19:06             ` Mel Gorman
2014-04-08 19:06               ` Mel Gorman
2014-04-08 19:08             ` Rik van Riel
2014-04-08 19:08               ` Rik van Riel
2014-04-08 17:03       ` Mel Gorman
2014-04-08 17:03         ` Mel Gorman
2014-04-08 17:30       ` Peter Zijlstra
2014-04-08 17:30         ` Peter Zijlstra
2014-04-08 17:41         ` Linus Torvalds
2014-04-08 17:41           ` Linus Torvalds
2014-04-08 18:16         ` Cyrill Gorcunov
2014-04-08 18:16           ` Cyrill Gorcunov
2014-04-09  6:21         ` Ingo Molnar
2014-04-09  6:21           ` Ingo Molnar
2014-04-09 23:34           ` H. Peter Anvin
2014-04-09 23:34             ` H. Peter Anvin
2014-04-10  0:12             ` Linus Torvalds
2014-04-10  0:12               ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53440A5D.6050301@zytor.com \
    --to=hpa@zytor.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=david.vrabel@citrix.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=steven@uplinklabs.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.