diff for duplicates of <53440A90.2030501@gmail.com> diff --git a/a/1.txt b/N1/1.txt index b33bb67..f554c6c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -84,19 +84,19 @@ not to change. > + for (tmp = list_next_entry(tmp, asocs); 1; -Why not change the stop condition to tmp = asoc. It should work +Why not change the stop condition to tmp == asoc. It should work since it will not be head pointer. -vlad > + tmp = list_next_entry(tmp, asocs)) { > + /* Manually skip the head element. */ -> + if (&tmp->asocs = &((sctp_sk(sk))->ep->asocs)) +> + if (&tmp->asocs == &((sctp_sk(sk))->ep->asocs)) > + continue; > + /* Wake up association. */ > + __sctp_write_space(tmp); > + /* We've reached the end. */ -> + if (tmp = asoc) +> + if (tmp == asoc) > + break; > + } > +} diff --git a/a/content_digest b/N1/content_digest index 371a707..77a1332 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01396964037-13245-1-git-send-email-dborkman@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket\0" - "Date\0Tue, 08 Apr 2014 14:41:20 +0000\0" + "Date\0Tue, 08 Apr 2014 10:41:20 -0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>" " davem@davemloft.net\0" "Cc\0netdev@vger.kernel.org" @@ -96,19 +96,19 @@ "\n" "> +\tfor (tmp = list_next_entry(tmp, asocs); 1;\n" "\n" - "Why not change the stop condition to tmp = asoc. It should work\n" + "Why not change the stop condition to tmp == asoc. It should work\n" "since it will not be head pointer.\n" "\n" "-vlad\n" "\n" "> +\t tmp = list_next_entry(tmp, asocs)) {\n" "> +\t\t/* Manually skip the head element. */\n" - "> +\t\tif (&tmp->asocs = &((sctp_sk(sk))->ep->asocs))\n" + "> +\t\tif (&tmp->asocs == &((sctp_sk(sk))->ep->asocs))\n" "> +\t\t\tcontinue;\n" "> +\t\t/* Wake up association. */\n" "> +\t\t__sctp_write_space(tmp);\n" "> +\t\t/* We've reached the end. */\n" - "> +\t\tif (tmp = asoc)\n" + "> +\t\tif (tmp == asoc)\n" "> +\t\t\tbreak;\n" "> +\t}\n" "> +}\n" @@ -127,4 +127,4 @@ "> }\n" > -0d4ab52917d9339e1b0569e86602ac5c672f4ed1cd86fdadecc96fb509050af1 +3ca7aa61da004ccde3c7e22c237e618491b615680b419ddf42edb8541aca60cf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.