diff for duplicates of <53440D33.2000809@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 3993086..dde453c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -87,7 +87,7 @@ Ok, will add that to the comment and respin, thanks Vlad. >> + for (tmp = list_next_entry(tmp, asocs); 1; > -> Why not change the stop condition to tmp = asoc. It should work +> Why not change the stop condition to tmp == asoc. It should work > since it will not be head pointer. If I see this correctly, wouldn't we then exclude to eventually @@ -98,12 +98,12 @@ sure to wake us up? > >> + tmp = list_next_entry(tmp, asocs)) { >> + /* Manually skip the head element. */ ->> + if (&tmp->asocs = &((sctp_sk(sk))->ep->asocs)) +>> + if (&tmp->asocs == &((sctp_sk(sk))->ep->asocs)) >> + continue; >> + /* Wake up association. */ >> + __sctp_write_space(tmp); >> + /* We've reached the end. */ ->> + if (tmp = asoc) +>> + if (tmp == asoc) >> + break; >> + } >> +} diff --git a/a/content_digest b/N1/content_digest index cc92bb5..5487443 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\053440A90.2030501@gmail.com\0" "From\0Daniel Borkmann <dborkman@redhat.com>\0" "Subject\0Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket\0" - "Date\0Tue, 08 Apr 2014 14:52:35 +0000\0" + "Date\0Tue, 08 Apr 2014 16:52:35 +0200\0" "To\0Vlad Yasevich <vyasevich@gmail.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -100,7 +100,7 @@ "\n" ">> +\tfor (tmp = list_next_entry(tmp, asocs); 1;\n" ">\n" - "> Why not change the stop condition to tmp = asoc. It should work\n" + "> Why not change the stop condition to tmp == asoc. It should work\n" "> since it will not be head pointer.\n" "\n" "If I see this correctly, wouldn't we then exclude to eventually\n" @@ -111,12 +111,12 @@ ">\n" ">> +\t tmp = list_next_entry(tmp, asocs)) {\n" ">> +\t\t/* Manually skip the head element. */\n" - ">> +\t\tif (&tmp->asocs = &((sctp_sk(sk))->ep->asocs))\n" + ">> +\t\tif (&tmp->asocs == &((sctp_sk(sk))->ep->asocs))\n" ">> +\t\t\tcontinue;\n" ">> +\t\t/* Wake up association. */\n" ">> +\t\t__sctp_write_space(tmp);\n" ">> +\t\t/* We've reached the end. */\n" - ">> +\t\tif (tmp = asoc)\n" + ">> +\t\tif (tmp == asoc)\n" ">> +\t\t\tbreak;\n" ">> +\t}\n" ">> +}\n" @@ -136,4 +136,4 @@ ">>\n" > -ad14239570ee52ca791cce5919a17323f4e77fc0f1cbcc639dd026f24b2924bc +f2da5413e009038f0038feb07e31fed961e9ba02606f2d5dccb0c65900213403
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.