All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/4] tools: arm: report an error if the guest RAM is too large
Date: Tue, 08 Apr 2014 15:55:08 +0100	[thread overview]
Message-ID: <53440DCC.6010002@linaro.org> (raw)
In-Reply-To: <1396966760-7752-1-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 04/08/2014 03:19 PM, Ian Campbell wrote:
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 7496556..dc11040 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -369,7 +369,8 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_GICC_BASE   0x2c002000ULL
>  #define GUEST_GICC_SIZE   0x100ULL
>  
> -#define GUEST_RAM_BASE    0x80000000ULL
> +#define GUEST_RAM_BASE    0x80000000ULL /* 768M at 2GB*/
> +#define GUEST_RAM_END     0xafffffffULL

I didn't catch this on the first read, every other pairs of define use
_BASE AND _SIZE. Can you be consistent here?

Regards,

-- 
Julien Grall

  parent reply	other threads:[~2014-04-08 14:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 14:18 [PATCH 0/4] xen: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-04-08 14:19 ` [PATCH 1/4] tools: arm: report an error if the guest RAM is too large Ian Campbell
2014-04-08 14:50   ` Julien Grall
2014-04-08 14:55   ` Julien Grall [this message]
2014-04-08 15:06     ` Ian Campbell
2014-04-08 15:16       ` Julien Grall
2014-04-08 14:19 ` [PATCH 2/4] xen: arm: move magic pfns out of guest RAM region Ian Campbell
2014-04-08 14:52   ` Julien Grall
2014-04-08 14:19 ` [PATCH 3/4] xen: arm: rearrange guest physical address space to increase max RAM Ian Campbell
2014-04-08 15:12   ` Julien Grall
2014-04-08 15:22     ` Ian Campbell
2014-04-08 16:01       ` Julien Grall
2014-04-09  7:59         ` Ian Campbell
2014-04-08 14:19 ` [PATCH 4/4] xen: arm: support up to (almost) 1TB of guest RAM Ian Campbell
2014-04-08 15:35   ` Julien Grall
2014-04-08 15:43     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53440DCC.6010002@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.