All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balakumaran Kannan <kumaran.4353@gmail.com>
To: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: [PATCH v2] net phylib: Remove unnecessary condition check
Date: Tue, 08 Apr 2014 20:51:05 +0530	[thread overview]
Message-ID: <534413E1.8070205@gmail.com> (raw)

This condition check makes no difference in the code flow since 3.10

Signed-off-by: Balakumaran Kannan <kumaran.4353@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

---
 drivers/net/phy/phy.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1d788f1..1b6d09a 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -756,12 +756,8 @@ void phy_state_machine(struct work_struct *work)
			netif_carrier_on(phydev->attached_dev);
			phydev->adjust_link(phydev->attached_dev);

-		} else if (0 == phydev->link_timeout--) {
+		} else if (0 == phydev->link_timeout--)
			needs_aneg = 1;
-			/* If we have the magic_aneg bit, we try again */
-			if (phydev->drv->flags & PHY_HAS_MAGICANEG)
-				break;
-		}
		break;
	case PHY_NOLINK:
		err = phy_read_status(phydev);
-- 1.7.9.5 

             reply	other threads:[~2014-04-08 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 15:21 Balakumaran Kannan [this message]
2014-04-08 17:03 ` [PATCH v2] net phylib: Remove unnecessary condition check David Miller
2014-04-09  3:28   ` Balakumaran Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534413E1.8070205@gmail.com \
    --to=kumaran.4353@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.