diff for duplicates of <53441531.8030009@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 1b571e6..adb2501 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -89,7 +89,7 @@ On 04/08/2014 10:52 AM, Daniel Borkmann wrote: > >>> + for (tmp = list_next_entry(tmp, asocs); 1; >> ->> Why not change the stop condition to tmp = asoc. It should work +>> Why not change the stop condition to tmp == asoc. It should work >> since it will not be head pointer. > > If I see this correctly, wouldn't we then exclude to eventually @@ -108,12 +108,12 @@ resurrect that code for net-next. >> >>> + tmp = list_next_entry(tmp, asocs)) { >>> + /* Manually skip the head element. */ ->>> + if (&tmp->asocs = &((sctp_sk(sk))->ep->asocs)) +>>> + if (&tmp->asocs == &((sctp_sk(sk))->ep->asocs)) >>> + continue; >>> + /* Wake up association. */ >>> + __sctp_write_space(tmp); >>> + /* We've reached the end. */ ->>> + if (tmp = asoc) +>>> + if (tmp == asoc) >>> + break; >>> + } >>> +} diff --git a/a/content_digest b/N1/content_digest index 5d95757..fce50d4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\053440D33.2000809@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net] net: sctp: wake up all assocs if sndbuf policy is per socket\0" - "Date\0Tue, 08 Apr 2014 15:26:41 +0000\0" + "Date\0Tue, 08 Apr 2014 11:26:41 -0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -103,7 +103,7 @@ "> \n" ">>> + for (tmp = list_next_entry(tmp, asocs); 1;\n" ">>\n" - ">> Why not change the stop condition to tmp = asoc. It should work\n" + ">> Why not change the stop condition to tmp == asoc. It should work\n" ">> since it will not be head pointer.\n" "> \n" "> If I see this correctly, wouldn't we then exclude to eventually\n" @@ -122,12 +122,12 @@ ">>\n" ">>> + tmp = list_next_entry(tmp, asocs)) {\n" ">>> + /* Manually skip the head element. */\n" - ">>> + if (&tmp->asocs = &((sctp_sk(sk))->ep->asocs))\n" + ">>> + if (&tmp->asocs == &((sctp_sk(sk))->ep->asocs))\n" ">>> + continue;\n" ">>> + /* Wake up association. */\n" ">>> + __sctp_write_space(tmp);\n" ">>> + /* We've reached the end. */\n" - ">>> + if (tmp = asoc)\n" + ">>> + if (tmp == asoc)\n" ">>> + break;\n" ">>> + }\n" ">>> +}\n" @@ -148,4 +148,4 @@ ">>>\n" >> -e533020dcbce74f927d3662822c6f23633d38bcd5773fd656f727b1c29dcf2a5 +81c5baa432b45dcce428d50c62069797a5537791cd06799d52d1380a9b5beffd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.