From: mmarek@suse.cz (Michal Marek)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
Date: Tue, 08 Apr 2014 17:29:54 +0200 [thread overview]
Message-ID: <534415F2.7020601@suse.cz> (raw)
In-Reply-To: <1390805482-25075-1-git-send-email-sachin.kamat@linaro.org>
On 2014-01-27 07:51, Sachin Kamat wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to kbuild.git#misc, sorry for the delay. But please always add
lkml to the cc list.
Thanks,
Michal
> ---
> scripts/coccinelle/api/ptr_ret.cocci | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index e18f8402e37c..dd58dab5d411 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -7,7 +7,7 @@
> // URL: http://coccinelle.lip6.fr/
> // Options: --no-includes --include-headers
> //
> -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
> // Version min: 2.6.39
> //
>
> @@ -62,35 +62,35 @@ position p3;
> p << r1.p1;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>
> @script:python depends on org@
> p << r2.p2;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on org@
> p << r3.p3;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r1.p1;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r2.p2;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r3.p3;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: cocci@systeme.lip6.fr, Julia.Lawall@lip6.fr,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, patches@linaro.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO
Date: Tue, 08 Apr 2014 17:29:54 +0200 [thread overview]
Message-ID: <534415F2.7020601@suse.cz> (raw)
In-Reply-To: <1390805482-25075-1-git-send-email-sachin.kamat@linaro.org>
On 2014-01-27 07:51, Sachin Kamat wrote:
> PTR_RET is deprecated. Do not recommend its usage anymore.
> Use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to kbuild.git#misc, sorry for the delay. But please always add
lkml to the cc list.
Thanks,
Michal
> ---
> scripts/coccinelle/api/ptr_ret.cocci | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index e18f8402e37c..dd58dab5d411 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -7,7 +7,7 @@
> // URL: http://coccinelle.lip6.fr/
> // Options: --no-includes --include-headers
> //
> -// Keywords: ERR_PTR, PTR_ERR, PTR_RET, PTR_ERR_OR_ZERO
> +// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO
> // Version min: 2.6.39
> //
>
> @@ -62,35 +62,35 @@ position p3;
> p << r1.p1;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
>
> @script:python depends on org@
> p << r2.p2;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on org@
> p << r3.p3;
> @@
>
> -coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r1.p1;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r2.p2;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
> @script:python depends on report@
> p << r3.p3;
> @@
>
> -coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")
>
next prev parent reply other threads:[~2014-04-08 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 6:51 [Cocci] [PATCH] scripts/coccinelle: Use PTR_ERR_OR_ZERO Sachin Kamat
2014-02-06 3:09 ` Sachin Kamat
2014-02-08 20:11 ` Julia Lawall
2014-02-17 4:01 ` Sachin Kamat
2014-03-10 15:27 ` Sachin Kamat
2014-04-08 15:29 ` Michal Marek [this message]
2014-04-08 15:29 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534415F2.7020601@suse.cz \
--to=mmarek@suse.cz \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.