From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXYoo-0000o5-PY for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:24:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXYoj-0001jb-Qi for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:24:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXYoj-0001jG-IR for qemu-devel@nongnu.org; Tue, 08 Apr 2014 12:24:09 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s38GO82l004319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Apr 2014 12:24:09 -0400 Message-ID: <534422A7.7040301@redhat.com> Date: Tue, 08 Apr 2014 10:24:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396961442-24046-1-git-send-email-mreitz@redhat.com> <1396961442-24046-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1396961442-24046-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xcu3M1Wg5JJFdxV0B5PQ3bFWEdRaMpV0O" Subject: Re: [Qemu-devel] [PATCH v2 2/6] block-commit: speed is an optional parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xcu3M1Wg5JJFdxV0B5PQ3bFWEdRaMpV0O Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/08/2014 06:50 AM, Max Reitz wrote: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake >=20 > diff --git a/blockdev.c b/blockdev.c > index b988cc5..9d7bd04 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1876,6 +1876,9 @@ void qmp_block_commit(const char *device, > */ > BlockdevOnError on_error =3D BLOCKDEV_ON_ERROR_REPORT; > =20 > + if (!has_speed) { > + speed =3D 0; > + } > if (!has_granularity) { > granularity =3D 0; > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xcu3M1Wg5JJFdxV0B5PQ3bFWEdRaMpV0O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTRCKoAAoJEKeha0olJ0Nqc6YH/jnSFNn+NzAwW3sv9HmUJ7v2 nwsaU1Gmxji4yhdWigjF0RKMwvglAWjYu35ZfhgHY2l/DPF9x0Wm+CMwc1iXK8lm Td+RunEfIGtZdDsvf72ixbazDfMFkQCumNguncW3K3iaUAIT8r7E/H2r3FG/e2fr Kji8Wfq2kJeKBxijLuQlO+LSvdsj69kS26ug+B2znXkKz6E2Fr52iHf5CmKVwmtC g47rBdPslk2rgpxRTQFhi5B/jr+1a6HaWBsgt+CT1Gn2Yo7vCU1LMCf5pT8gOcTr EMmgkDHqrGU9K3plMrUyx8vvNn+mEzgs67rlpBgjm6wMUKyS+bONhroWllarUPE= =bxoE -----END PGP SIGNATURE----- --Xcu3M1Wg5JJFdxV0B5PQ3bFWEdRaMpV0O--