Re: [Qemu-devel] [PATCH 1/1] monitor: Add pmemload command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

On 04/08/2014 11:17 AM, Baojun Wang wrote:
> Hi list,
> 
> Is it possible to add a monitor command ``pmemload'' as pmemsave?
> I found this could be useful to have qemu-softmmu as a cross debugger
> (launch with -s -S command line option), then if we can have a command to
> load guest physical memory, we can use cross gdb to do some target debug
> which gdb cannot do directly.
> 
> Attachment is a trivial patch add pmemload monitor command.

We prefer patches sent inline via 'git send-email', as they are easier
to reply to.


> +++ b/qapi-schema.json
> @@ -1708,6 +1708,26 @@
>    'data': {'val': 'int', 'size': 'int', 'filename': 'str'} }
>  
>  ##
> +# @pmemload:
> +#
> +# Load a portion of guest physical memory from a file.
> +#
> +# @val: the physical address of the guest to start from
> +#
> +# @size: the size of memory region to save

s/save/load/ ?

> +#
> +# @filename: the file to load the memory from as binary data
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 2.0

You've missed 2.0; at the earliest, this would be 2.1.

> +#
> +# Notes: Errors were not reliably returned until 1.1

This note is bogus copy and paste - since the command is new to 2.1,
there is no unreliable error handling in 1.1.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]