From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"Alexander Graf" <agraf@suse.de>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region
Date: Tue, 08 Apr 2014 14:39:37 -0400 [thread overview]
Message-ID: <53444269.2010906@redhat.com> (raw)
In-Reply-To: <CAFEAcA-oDUiWxbOkRhpEkqgfg+hukrr+eheKPMYZdAcKOpeSZA@mail.gmail.com>
Il 08/04/2014 10:37, Peter Maydell ha scritto:
> I think it's actually worse than that. address_space_read/write
> have an API which requires you to pass them a buffer which is
> in guest CPU endianness. This means they cannot be used from
> target-independent source files (like hw/pci-host/prep.c)
> because there's no way to say "write this 32 bit value to
> the buffer in target endianness". ioport.c which has pretty
> much identical code works OK because it is built per target.
So the fix could be to compile prep.c per-target (and change to
DEVICE_NATIVE_ENDIAN too).
> Worse, we have two versions of the ldl_p()/stl_p() &c
> functions with conflicting semantics!
> cpu-all.h defines these to be "target CPU endianness".
> bswap.h defines these to be "host CPU endianness".
Ouch! I have some cleanups for CPU ld/st ready for 2.1, I'll add a
patch to rename bswap.h's definition to ldl_host_p/stl_host_p.
Paolo
next prev parent reply other threads:[~2014-04-08 18:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 23:35 [Qemu-devel] [PULL for-2.0-rc1 0/7] PReP patch queue 2014-03-20 Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 1/7] raven: Rename intack region to pci_intack Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region Andreas Färber
2014-04-05 15:41 ` Andreas Färber
2014-04-05 20:26 ` Hervé Poussineau
2014-04-05 20:34 ` Alexander Graf
2014-04-05 20:50 ` Hervé Poussineau
2014-04-05 23:20 ` Peter Maydell
2014-04-07 19:31 ` Paolo Bonzini
2014-04-08 14:37 ` Peter Maydell
2014-04-08 18:39 ` Paolo Bonzini [this message]
2014-04-08 18:55 ` Peter Maydell
2014-04-08 20:27 ` Paolo Bonzini
2014-04-08 20:56 ` Peter Maydell
2014-04-07 19:32 ` Andreas Färber
2014-04-07 20:40 ` Andreas Färber
2014-04-07 21:21 ` Peter Maydell
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 3/7] raven: Set a correct PCI I/O memory region Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 4/7] raven: Set a correct PCI " Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 5/7] raven: Add PCI bus mastering address space Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 6/7] raven: Fix PCI bus accesses with size > 1 Andreas Färber
2014-03-19 23:36 ` [Qemu-devel] [PULL for-2.0 7/7] raven: Use raven_ for all function prefixes Andreas Färber
2014-03-20 0:22 ` [Qemu-devel] [PULL for-2.0-rc1 0/7] PReP patch queue 2014-03-20 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53444269.2010906@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=hpoussin@reactos.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.