From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Patch to compile grub2 with Apple compiler
Date: Tue, 08 Apr 2014 23:47:12 +0200 [thread overview]
Message-ID: <53446E60.4040607@gmail.com> (raw)
In-Reply-To: <C8BF8952-82F9-4207-8EE7-2461297D9585@zetam.org>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
On 08.04.2014 14:27, Yves Blusseau wrote:
>
> Le 8 avr. 2014 à 11:00, Vladimir 'phcoder' Serbinenko <phcoder@gmail.com
> <mailto:phcoder@gmail.com>> a écrit :
>
>>
>> On 8 Apr 2014 10:55, "Yves Blusseau" <blusseau@zetam.org
>> <mailto:blusseau@zetam.org>> wrote:
>> >
>> > Hi Vladimir,
>> >
>> > this patch is needed because the declaration of __bzero must made
>> also for non util AND util compilation: __bzero is used in compilation
>> of grub-core/kern/misc.c (line 546).
>> >
>> > Without this patch we have this error: http://pastebin.com/aiPGcte0
>> > So the declaration must be made even if GRUB_UTIL is defined.
>> >
>> Not true. You just need to guard implementation as well
>>
> Don’t understand. What is the solution to solve the problem of compilation ?
>
diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index 54db2e1..c5c815d 100644
--- a/grub-core/kern/misc.c
+++ b/grub-core/kern/misc.c
@@ -542,6 +542,9 @@ memset (void *s, int c, grub_size_t n)
return grub_memset (s, c, n);
}
+#endif
+
+#if !defined(GRUB_UTIL) && defined(__APPLE__)
void GRUB_BUILTIN_ATTR
__bzero (void *s, grub_size_t n)
{
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]
next prev parent reply other threads:[~2014-04-08 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 11:21 Patch to compile grub2 with Apple compiler Yves Blusseau
2014-04-07 15:04 ` SevenBits
2014-04-07 19:52 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-04-07 20:34 ` SevenBits
2014-04-07 21:13 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-04-07 19:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-04-08 8:54 ` Yves Blusseau
2014-04-08 9:00 ` Vladimir 'phcoder' Serbinenko
2014-04-08 12:27 ` Yves Blusseau
2014-04-08 21:47 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2014-04-08 21:50 ` SevenBits
2014-04-08 22:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-04-09 11:11 ` Yves Blusseau
2014-04-10 21:20 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-04-12 9:00 ` Yves Blusseau
2014-04-12 11:27 ` Yves Blusseau
2014-04-12 17:06 ` Andrey Borzenkov
2014-04-12 17:54 ` Yves Blusseau
2014-04-20 14:10 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-05-02 10:33 ` Yves Blusseau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53446E60.4040607@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.