From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [lttng-dev] [PATCH 1/1] Disable liblttng-ust-dl if dlinfo is not available in C library.
Date: Wed, 09 Apr 2014 01:20:15 +0200 [thread overview]
Message-ID: <5344842F.3070901@openwide.fr> (raw)
In-Reply-To: <20140408172442.GB3199@free.fr>
Hi Simon, Yann,
Le 08/04/2014 19:24, Yann E. MORIN a ?crit :
> Simon, All,
>
> On 2014-04-08 13:03 -0400, Simon Marchi spake thusly:
>> Hi Romain,
>>
>> It seems like with that commit, dlinfo is not found even on a glibc
>> based system, where it is present.
>>
>> See https://bugs.lttng.org/issues/778
>>
>> Do you have a suggestion to fix that ?
> I think we should use AC_CHECK_DECL instead of AC_CHECK_FUNCS.
>
> dlinfo is in dlfcn.h so we need a check that allows us to include that
> header, and we must check for that header first, of course. So, maybe
> something like (completely untested, directly written in the mail):
>
> AC_CHECK_HEADER([dlfcn.h])
> AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"],
> [AC_CHECK_DECL([dlinfo],,,[dlfcn.h])],
> [ac_cv_have_decl_dlinfo="no"])
> AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_dlinfo}" = "yes"])
>
> But I'm no expert in autoconf, so the actual solution may be slightly
> different.
>
> Regards,
> Yann E. MORIN.
>
Sorry for the mistake, here is a new try:
AC_CHECK_HEADER([dlfcn.h])
AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"],
[AC_CHECK_DECLS([RTLD_DI_LINKMAP],,,
[#define _GNU_SOURCE /* Required on Linux to get GNU extensions */
#include <dlfcn.h>])
],
[ac_cv_have_decl_RTLD_DI_LINKMAP="no"])
AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_RTLD_DI_LINKMAP}"
= "yes"])
I can't use dlinfo directly here because it isdetected
even if it is not available in uClibc. (detected fromust-dlfcn.h ?)
So, I use RTLD_DI_LINKMAP which is not defined in uClibc.
I'll send the patch later (after doing some test)
Best regards,
Romain Naour
WARNING: multiple messages have this Message-ID (diff)
From: Romain Naour <romain.naour-oid7hba3+9NWj0EZb7rXcA@public.gmane.org>
To: "Yann E. MORIN" <yann.morin.1998-GANU6spQydw@public.gmane.org>,
Simon Marchi
<simon.marchi-scC8bbJcJLCw5LPnMra/2Q@public.gmane.org>
Cc: buildroot <buildroot-9GAsQqxh4YTR7s880joybQ@public.gmane.org>,
"lttng-dev-bnB2LGs2QVJ+nrgayQ7rhA@public.gmane.org"
<lttng-dev-bnB2LGs2QVJ+nrgayQ7rhA@public.gmane.org>,
Mathieu Desnoyers
<mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
Subject: Re: [lttng-dev] [PATCH 1/1] Disable liblttng-ust-dl if dlinfo is not available in C library.
Date: Wed, 09 Apr 2014 01:20:15 +0200 [thread overview]
Message-ID: <5344842F.3070901@openwide.fr> (raw)
In-Reply-To: <20140408172442.GB3199-GANU6spQydw@public.gmane.org>
Hi Simon, Yann,
Le 08/04/2014 19:24, Yann E. MORIN a écrit :
> Simon, All,
>
> On 2014-04-08 13:03 -0400, Simon Marchi spake thusly:
>> Hi Romain,
>>
>> It seems like with that commit, dlinfo is not found even on a glibc
>> based system, where it is present.
>>
>> See https://bugs.lttng.org/issues/778
>>
>> Do you have a suggestion to fix that ?
> I think we should use AC_CHECK_DECL instead of AC_CHECK_FUNCS.
>
> dlinfo is in dlfcn.h so we need a check that allows us to include that
> header, and we must check for that header first, of course. So, maybe
> something like (completely untested, directly written in the mail):
>
> AC_CHECK_HEADER([dlfcn.h])
> AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"],
> [AC_CHECK_DECL([dlinfo],,,[dlfcn.h])],
> [ac_cv_have_decl_dlinfo="no"])
> AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_dlinfo}" = "yes"])
>
> But I'm no expert in autoconf, so the actual solution may be slightly
> different.
>
> Regards,
> Yann E. MORIN.
>
Sorry for the mistake, here is a new try:
AC_CHECK_HEADER([dlfcn.h])
AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"],
[AC_CHECK_DECLS([RTLD_DI_LINKMAP],,,
[#define _GNU_SOURCE /* Required on Linux to get GNU extensions */
#include <dlfcn.h>])
],
[ac_cv_have_decl_RTLD_DI_LINKMAP="no"])
AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_RTLD_DI_LINKMAP}"
= "yes"])
I can't use dlinfo directly here because it isdetected
even if it is not available in uClibc. (detected fromust-dlfcn.h ?)
So, I use RTLD_DI_LINKMAP which is not defined in uClibc.
I'll send the patch later (after doing some test)
Best regards,
Romain Naour
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2014-04-08 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396818161-20204-1-git-send-email-romain.naour@openwide.fr>
2014-04-07 20:42 ` [PATCH 1/1] Disable liblttng-ust-dl if dlinfo is not available in C library Mathieu Desnoyers
[not found] ` <794709247.8287.1396903345152.JavaMail.zimbra@efficios.com>
2014-04-07 20:46 ` [Buildroot] [lttng-dev] " Romain Naour
2014-04-07 20:46 ` Romain Naour
2014-04-08 17:03 ` Simon Marchi
[not found] ` <CAFXXi0kAZJDD7ygqs493ZPvJHMpkeuMTDvxHqMg9B722pJHHxQ@mail.gmail.com>
2014-04-08 17:24 ` [Buildroot] [lttng-dev] " Yann E. MORIN
2014-04-08 17:24 ` Yann E. MORIN
2014-04-08 23:20 ` Romain Naour [this message]
2014-04-08 23:20 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5344842F.3070901@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.