From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Naour Date: Wed, 09 Apr 2014 01:20:15 +0200 Subject: [Buildroot] [lttng-dev] [PATCH 1/1] Disable liblttng-ust-dl if dlinfo is not available in C library. In-Reply-To: <20140408172442.GB3199@free.fr> References: <1396818161-20204-1-git-send-email-romain.naour@openwide.fr> <794709247.8287.1396903345152.JavaMail.zimbra@efficios.com> <53430E92.9060401@openwide.fr> <20140408172442.GB3199@free.fr> Message-ID: <5344842F.3070901@openwide.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Simon, Yann, Le 08/04/2014 19:24, Yann E. MORIN a ?crit : > Simon, All, > > On 2014-04-08 13:03 -0400, Simon Marchi spake thusly: >> Hi Romain, >> >> It seems like with that commit, dlinfo is not found even on a glibc >> based system, where it is present. >> >> See https://bugs.lttng.org/issues/778 >> >> Do you have a suggestion to fix that ? > I think we should use AC_CHECK_DECL instead of AC_CHECK_FUNCS. > > dlinfo is in dlfcn.h so we need a check that allows us to include that > header, and we must check for that header first, of course. So, maybe > something like (completely untested, directly written in the mail): > > AC_CHECK_HEADER([dlfcn.h]) > AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"], > [AC_CHECK_DECL([dlinfo],,,[dlfcn.h])], > [ac_cv_have_decl_dlinfo="no"]) > AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_dlinfo}" = "yes"]) > > But I'm no expert in autoconf, so the actual solution may be slightly > different. > > Regards, > Yann E. MORIN. > Sorry for the mistake, here is a new try: AC_CHECK_HEADER([dlfcn.h]) AS_IF([test "${ac_cv_header_dlfcn_h}" = "yes"], [AC_CHECK_DECLS([RTLD_DI_LINKMAP],,, [#define _GNU_SOURCE /* Required on Linux to get GNU extensions */ #include ]) ], [ac_cv_have_decl_RTLD_DI_LINKMAP="no"]) AM_CONDITIONAL([HAVE_DLINFO], [test "${ac_cv_have_decl_RTLD_DI_LINKMAP}" = "yes"]) I can't use dlinfo directly here because it isdetected even if it is not available in uClibc. (detected fromust-dlfcn.h ?) So, I use RTLD_DI_LINKMAP which is not defined in uClibc. I'll send the patch later (after doing some test) Best regards, Romain Naour From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Naour Subject: Re: [lttng-dev] [PATCH 1/1] Disable liblttng-ust-dl if dlinfo is not available in C library. Date: Wed, 09 Apr 2014 01:20:15 +0200 Message-ID: <5344842F.3070901@openwide.fr> References: <1396818161-20204-1-git-send-email-romain.naour@openwide.fr> <794709247.8287.1396903345152.JavaMail.zimbra@efficios.com> <53430E92.9060401@openwide.fr> <20140408172442.GB3199@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140408172442.GB3199-GANU6spQydw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces-9GAsQqxh4YTR7s880joybQ@public.gmane.org Sender: buildroot-bounces-9GAsQqxh4YTR7s880joybQ@public.gmane.org To: "Yann E. MORIN" , Simon Marchi Cc: buildroot , "lttng-dev-bnB2LGs2QVJ+nrgayQ7rhA@public.gmane.org" , Mathieu Desnoyers List-Id: lttng-dev@lists.lttng.org SGkgU2ltb24sIFlhbm4sCgpMZSAwOC8wNC8yMDE0IDE5OjI0LCBZYW5uIEUuIE1PUklOIGEgw6lj cml0IDoKPiBTaW1vbiwgQWxsLAo+Cj4gT24gMjAxNC0wNC0wOCAxMzowMyAtMDQwMCwgU2ltb24g TWFyY2hpIHNwYWtlIHRodXNseToKPj4gSGkgUm9tYWluLAo+Pgo+PiBJdCBzZWVtcyBsaWtlIHdp dGggdGhhdCBjb21taXQsIGRsaW5mbyBpcyBub3QgZm91bmQgZXZlbiBvbiBhIGdsaWJjCj4+IGJh c2VkIHN5c3RlbSwgd2hlcmUgaXQgaXMgcHJlc2VudC4KPj4KPj4gU2VlIGh0dHBzOi8vYnVncy5s dHRuZy5vcmcvaXNzdWVzLzc3OAo+Pgo+PiBEbyB5b3UgaGF2ZSBhIHN1Z2dlc3Rpb24gdG8gZml4 IHRoYXQgPwo+IEkgdGhpbmsgd2Ugc2hvdWxkIHVzZSBBQ19DSEVDS19ERUNMIGluc3RlYWQgb2Yg QUNfQ0hFQ0tfRlVOQ1MuCj4KPiBkbGluZm8gaXMgaW4gZGxmY24uaCBzbyB3ZSBuZWVkIGEgY2hl Y2sgdGhhdCBhbGxvd3MgdXMgdG8gaW5jbHVkZSB0aGF0Cj4gaGVhZGVyLCBhbmQgd2UgbXVzdCBj aGVjayBmb3IgdGhhdCBoZWFkZXIgZmlyc3QsIG9mIGNvdXJzZS4gU28sIG1heWJlCj4gc29tZXRo aW5nIGxpa2UgKGNvbXBsZXRlbHkgdW50ZXN0ZWQsIGRpcmVjdGx5IHdyaXR0ZW4gaW4gdGhlIG1h aWwpOgo+Cj4gICAgICBBQ19DSEVDS19IRUFERVIoW2RsZmNuLmhdKQo+ICAgICAgQVNfSUYoW3Rl c3QgIiR7YWNfY3ZfaGVhZGVyX2RsZmNuX2h9IiA9ICJ5ZXMiXSwKPiAgICAgICAgICAgIFtBQ19D SEVDS19ERUNMKFtkbGluZm9dLCwsW2RsZmNuLmhdKV0sCj4gICAgICAgICAgICBbYWNfY3ZfaGF2 ZV9kZWNsX2RsaW5mbz0ibm8iXSkKPiAgICAgIEFNX0NPTkRJVElPTkFMKFtIQVZFX0RMSU5GT10s IFt0ZXN0ICIke2FjX2N2X2hhdmVfZGVjbF9kbGluZm99IiA9ICJ5ZXMiXSkKPgo+IEJ1dCBJJ20g bm8gZXhwZXJ0IGluIGF1dG9jb25mLCBzbyB0aGUgYWN0dWFsIHNvbHV0aW9uIG1heSBiZSBzbGln aHRseQo+IGRpZmZlcmVudC4KPgo+IFJlZ2FyZHMsCj4gWWFubiBFLiBNT1JJTi4KPgpTb3JyeSBm b3IgdGhlIG1pc3Rha2UsIGhlcmUgaXMgYSBuZXcgdHJ5OgoKCkFDX0NIRUNLX0hFQURFUihbZGxm Y24uaF0pCkFTX0lGKFt0ZXN0ICIke2FjX2N2X2hlYWRlcl9kbGZjbl9ofSIgPSAieWVzIl0sCiAg ICAgW0FDX0NIRUNLX0RFQ0xTKFtSVExEX0RJX0xJTktNQVBdLCwsCiAgICAgICAgIFsjZGVmaW5l IF9HTlVfU09VUkNFIC8qIFJlcXVpcmVkIG9uIExpbnV4IHRvIGdldCBHTlUgZXh0ZW5zaW9ucyAq LwogICAgICAgICAjaW5jbHVkZSA8ZGxmY24uaD5dKQogICAgIF0sCiAgICAgW2FjX2N2X2hhdmVf ZGVjbF9SVExEX0RJX0xJTktNQVA9Im5vIl0pCkFNX0NPTkRJVElPTkFMKFtIQVZFX0RMSU5GT10s IFt0ZXN0ICIke2FjX2N2X2hhdmVfZGVjbF9SVExEX0RJX0xJTktNQVB9IiAKPSAieWVzIl0pCgoK SSBjYW4ndCB1c2UgZGxpbmZvIGRpcmVjdGx5IGhlcmUgYmVjYXVzZSBpdCBpc2RldGVjdGVkCmV2 ZW4gaWYgaXQgaXMgbm90IGF2YWlsYWJsZSBpbiB1Q2xpYmMuIChkZXRlY3RlZCBmcm9tdXN0LWRs ZmNuLmggPykKU28sIEkgdXNlIFJUTERfRElfTElOS01BUCB3aGljaCBpcyBub3QgZGVmaW5lZCBp biB1Q2xpYmMuCgpJJ2xsIHNlbmQgdGhlIHBhdGNoIGxhdGVyIChhZnRlciBkb2luZyBzb21lIHRl c3QpCgpCZXN0IHJlZ2FyZHMsClJvbWFpbiBOYW91cgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmJ1aWxkcm9vdCBtYWlsaW5nIGxpc3QKYnVpbGRyb290 QGJ1c3lib3gubmV0Cmh0dHA6Ly9saXN0cy5idXN5Ym94Lm5ldC9tYWlsbWFuL2xpc3RpbmZvL2J1 aWxkcm9vdA==