Re: [PATCH 1/2] watchdog: add Intel MID watchdog driver support

[Randy Dunlap <rdunlap@infradead.org>]

On 04/08/2014 01:59 PM, David Cohen wrote:
> Add initial Intel MID watchdog driver support.
> 
> This driver is an initial implementation of generic Intel MID watchdog
> driver. Currently it supports Intel Merrifield platform.
> 
> Signed-off-by: Eric Ernst <eric.ernst@intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
>  drivers/watchdog/Kconfig         |  12 +++
>  drivers/watchdog/Makefile        |   1 +
>  drivers/watchdog/intel-mid_wdt.c | 209 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 222 insertions(+)
>  create mode 100644 drivers/watchdog/intel-mid_wdt.c
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 79d25894343a..4da09b8b2f11 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -643,6 +643,18 @@ config INTEL_SCU_WATCHDOG
>  
>  	  To compile this driver as a module, choose M here.
>  
> +config INTEL_MID_WATCHDOG
> +	bool "Intel MID SCU Watchdog Mobile Platforms"
> +	depends on X86_INTEL_MID && WATCHDOG_CORE
> +	---help---
> +	  Watchdog timer driver built into the Intel SCU for Intel MID
> +	  Platforms.
> +
> +	  This driver currently supports only the watchdog evolution
> +	  implementation in SCU, available for Merrifield generation.
> +
> +	  To compile this driver as a module, choose M here.

Does choosing M work when INTEL_MID_WATCHDOG is a bool?
and why is INTEL_MID_WATCHDOG a bool?

> +
>  config ITCO_WDT
>  	tristate "Intel TCO Timer/Watchdog"
>  	depends on (X86 || IA64) && PCI


-- 
~Randy