From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/hotplug: Remove network-*
Date: Wed, 9 Apr 2014 11:14:17 +0200 [thread overview]
Message-ID: <53450F69.40602@citrix.com> (raw)
In-Reply-To: <1397034653.31448.29.camel@kazak.uk.xensource.com>
On 09/04/14 11:10, Ian Campbell wrote:
> On Wed, 2014-04-09 at 10:55 +0200, Roger Pau Monné wrote:
>> On 09/04/14 10:28, Ian Campbell wrote:
>>> These are a xend-ism. Since Xen 4.1 the recommened way to configure networking
>>> has been to use the distro facilities (e.g.
>>> http://wiki.xen.org/wiki/HostConfiguration/Networking)
>>>
>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>> ---
>>> tools/hotplug/Linux/network-bridge | 339 ------------------------------------
>>> tools/hotplug/Linux/network-nat | 124 -------------
>>> tools/hotplug/Linux/network-route | 28 ---
>>
>> Shouldn't you also modify tools/hotplug/Linux/Makefile to remove the
>> references to those files, or am I missing something?
>
> You aren't, I've no idea why this didn't fail for me before... I suspect
> I just didn't pay close enough attention to the test build.
>
> -----8<----------
>
> From 3f2142f0b7a0d600fa8d2d06b5eacf0d52aa5bca Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Fri, 4 Apr 2014 15:00:12 +0100
> Subject: [PATCH v2] tools/hotplug: Remove network-*
>
> These are a xend-ism. Since Xen 4.1 the recommened way to configure networking
> has been to use the distro facilities (e.g.
> http://wiki.xen.org/wiki/HostConfiguration/Networking)
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Now it looks fine :)
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-09 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 8:28 [PATCH] tools/hotplug: Remove network-* Ian Campbell
2014-04-09 8:55 ` Roger Pau Monné
2014-04-09 9:10 ` Ian Campbell
2014-04-09 9:14 ` Roger Pau Monné [this message]
2014-04-09 10:39 ` Ian Jackson
2014-04-10 11:36 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53450F69.40602@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.