From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver Date: Wed, 09 Apr 2014 12:01:04 +0200 Message-ID: <53451A60.4050803@samsung.com> References: <1396967856-27470-1-git-send-email-t.stanislaws@samsung.com> <1396967856-27470-2-git-send-email-t.stanislaws@samsung.com> <534506B1.4040908@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-media-owner@vger.kernel.org To: Rahul Sharma , Andrzej Hajda Cc: Tomasz Stanislawski , "linux-kernel@vger.kernel.org" , linux-samsung-soc , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Kukjin Kim , Kishon Vijay Abraham I , Kyungmin Park , Rob Herring , Grant Likely , Rahul Sharma , sunil joshi List-Id: linux-samsung-soc@vger.kernel.org Hi, On 09/04/14 11:12, Rahul Sharma wrote: > Idea looks good. How about keeping compatible which is independent > of SoC, something like "samsung,exynos-simple-phy" and provide Reg > and Bit through phy provider node. This way we can avoid SoC specific > hardcoding in phy driver and don't need to look into dt bindings for > each new SoC. I believe it is a not recommended approach. > We can use syscon interface to access PMU bits like USB phy. > PMU is already registered as system controller Yes, that sounds good. This way we could avoid overlapping memory mapped register regions specified in 'reg' properties in the device tree. -- Thanks, Sylwester