From: Tomasz Figa <t.figa@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: kishon <kishon@ti.com>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>, Felipe Balbi <balbi@ti.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Kamil Debski <k.debski@samsung.com>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off
Date: Wed, 09 Apr 2014 14:38:06 +0200 [thread overview]
Message-ID: <53453F2E.40606@samsung.com> (raw)
In-Reply-To: <CAFp+6iHf5Ndt3yNbdAaayXi08-A54Sk8LDTiASm4RTw09GuWvg@mail.gmail.com>
Hi,
On 09.04.2014 14:24, Vivek Gautam wrote:
> Hi Sylwester,
>
>
> On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki
> <s.nawrocki@samsung.com> wrote:
>> Hi Vivek,
>>
>> On 09/04/14 13:54, Vivek Gautam wrote:
>>> Adding support to enable/disable VBUS hooked to a gpio
>>> to enable vbus supply on the port.
>>
>> Does the GPIO control a fixed voltage regulator ? If so, shouldn't
>> it be modelled by the regulator API instead ?
>
> No, this GPIO controls a 'current limiting power distribution switch',
> which gives the output vbus to usb controller.
> Should i model this as a fixed regulator ?
If I understand this correctly, this is just a switch that lets you
control whether vbus is provided to the USB connector or not. If so,
this doesn't look like an Exynos-specific thing at all and should rather
be modeled on higher level.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off
Date: Wed, 09 Apr 2014 14:38:06 +0200 [thread overview]
Message-ID: <53453F2E.40606@samsung.com> (raw)
In-Reply-To: <CAFp+6iHf5Ndt3yNbdAaayXi08-A54Sk8LDTiASm4RTw09GuWvg@mail.gmail.com>
Hi,
On 09.04.2014 14:24, Vivek Gautam wrote:
> Hi Sylwester,
>
>
> On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki
> <s.nawrocki@samsung.com> wrote:
>> Hi Vivek,
>>
>> On 09/04/14 13:54, Vivek Gautam wrote:
>>> Adding support to enable/disable VBUS hooked to a gpio
>>> to enable vbus supply on the port.
>>
>> Does the GPIO control a fixed voltage regulator ? If so, shouldn't
>> it be modelled by the regulator API instead ?
>
> No, this GPIO controls a 'current limiting power distribution switch',
> which gives the output vbus to usb controller.
> Should i model this as a fixed regulator ?
If I understand this correctly, this is just a switch that lets you
control whether vbus is provided to the USB connector or not. If so,
this doesn't look like an Exynos-specific thing at all and should rather
be modeled on higher level.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-09 12:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:54 [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off Vivek Gautam
2014-04-09 11:54 ` Vivek Gautam
2014-04-09 12:11 ` Sylwester Nawrocki
2014-04-09 12:11 ` Sylwester Nawrocki
2014-04-09 12:24 ` Vivek Gautam
2014-04-09 12:24 ` Vivek Gautam
2014-04-09 12:38 ` Tomasz Figa [this message]
2014-04-09 12:38 ` Tomasz Figa
2014-04-10 11:07 ` Vivek Gautam
2014-04-10 11:07 ` Vivek Gautam
2014-04-09 13:08 ` Sylwester Nawrocki
2014-04-09 13:08 ` Sylwester Nawrocki
2014-04-10 9:09 ` Kishon Vijay Abraham I
2014-04-10 9:09 ` Kishon Vijay Abraham I
2014-04-10 9:09 ` Kishon Vijay Abraham I
2014-04-10 10:32 ` Vivek Gautam
2014-04-10 10:32 ` Vivek Gautam
2014-04-12 3:37 ` Felipe Balbi
2014-04-12 3:37 ` Felipe Balbi
2014-04-12 3:37 ` Felipe Balbi
2014-04-14 8:05 ` Vivek Gautam
2014-04-14 8:05 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53453F2E.40606@samsung.com \
--to=t.figa@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=k.debski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.