Re: [Qemu-devel] [libvirt] [PATCH 1/1] Enable QEMU_CAPS_PCI_MULTIBUS capability for QEMU2.0 forward.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

[adding qemu]

On 04/08/2014 11:36 PM, Li Zhang wrote:
> On 2014年04月09日 11:20, Eric Blake wrote:
>> On 04/08/2014 08:03 PM, Li Zhang wrote:
>>> From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
>>>
>>> For QEMU2.0 forward version, it supports PCI multiBUS.
>>> Currently, libvirt still disables it which causes an error
>>> "Bus 'pci' not found".
>>>
>>> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
>>> ---
>>>   src/qemu/qemu_capabilities.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>>> index 2c8ec10..b49398f 100644
>>> --- a/src/qemu/qemu_capabilities.c
>>> +++ b/src/qemu/qemu_capabilities.c
>>> @@ -3019,6 +3019,9 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
>>>       if (qemuCaps->version >= 1006000)
>>>           virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY);
>>>   +    if (qemuCaps->version >= 2000000)
>>> +        virQEMUCapsSet(qemuCaps, QEMU_CAPS_PCI_MULTIBUS);
>>> +
>> This is a version number check, which is bad.  Is there a QMP command we
>> can issue that gives a more reliable answer of whether the feature is
>> present?
>>
> Hi Eric,
> 
> I can't find any QMP command for MULTIBUS in QEMU.
> There is only one "query-pci" to list PCI bus and devices information.

Maybe it's my fault for not being more vocal when the bus rename was
being proposed on the qemu list, but libvirt really does want a way to
probe via QMP whether the 'pci.0' (multibus) vs. 'pci' naming should be
used for a given machine.  Is there an existing command we can use, or
is this something that we need to fix early on in qemu 2.1 and backport
to 2.0-stable?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]