From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 6/8] ioreq-server: remove p2m entries when server is enabled Date: Wed, 09 Apr 2014 14:50:34 +0100 Message-ID: <53456C4A0200007800007386@nat28.tlf.novell.com> References: <1396451496-5716-1-git-send-email-paul.durrant@citrix.com> <1396451496-5716-7-git-send-email-paul.durrant@citrix.com> <5345573002000078000071EC@nat28.tlf.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD02D3D5C@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD02D3D5C@AMSPEX01CL01.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: Ian Jackson , Stefano Stabellini , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org >>> On 09.04.14 at 15:36, wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> Also, you're pretty consistently naming the field/variable "enabled" >> rather than "enable", despite it being a transition you're invoking >> rather than obtaining state. > > Yes, because I'm setting whether the server state is 'enabled' or not. The > value of the boolean is the end state not the transition, so it's correct to > use the adjective rather than the verb. Hmm, that's not my way of thinking with operations like this. To me, the operation is to enable (or disable) the server, not to set its state to enabled (or disabled). But yes, one may view it your way too, even if I would think that's not commonly done (and I think I saw "enable"s too somewhere in the series, and maybe even in the same patch, so I'd be inclined to ask for consistency even if our ways of thinking of these operations differ). Jan