All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jonathan Callen <jcallen@gentoo.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/java.txt: add Java 7 support
Date: Wed, 09 Apr 2014 09:21:18 -0700	[thread overview]
Message-ID: <5345737E.4050008@infradead.org> (raw)
In-Reply-To: <1396237634-6634-1-git-send-email-jcallen@gentoo.org>

On 03/30/2014 08:47 PM, Jonathan Callen wrote:
> The sample wrapper currently fails on some Java 7 .class files.  This
> updates the wrapper to properly handle those files.
> 
> Signed-off-by: Jonathan Callen <jcallen@gentoo.org>

Applied.  Thanks.

How would I test this?


> ---
>  Documentation/java.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/java.txt b/Documentation/java.txt
> index e6a7232..4180205 100644
> --- a/Documentation/java.txt
> +++ b/Documentation/java.txt
> @@ -188,6 +188,9 @@ shift
>  #define CP_METHODREF 10
>  #define CP_INTERFACEMETHODREF 11
>  #define CP_NAMEANDTYPE 12
> +#define CP_METHODHANDLE 15
> +#define CP_METHODTYPE 16
> +#define CP_INVOKEDYNAMIC 18
>  
>  /* Define some commonly used error messages */
>  
> @@ -242,14 +245,19 @@ void skip_constant(FILE *classfile, u_int16_t *cur)
>  		break;
>  	case CP_CLASS:
>  	case CP_STRING:
> +	case CP_METHODTYPE:
>  		seekerr = fseek(classfile, 2, SEEK_CUR);
>  		break;
> +	case CP_METHODHANDLE:
> +		seekerr = fseek(classfile, 3, SEEK_CUR);
> +		break;
>  	case CP_INTEGER:
>  	case CP_FLOAT:
>  	case CP_FIELDREF:
>  	case CP_METHODREF:
>  	case CP_INTERFACEMETHODREF:
>  	case CP_NAMEANDTYPE:
> +	case CP_INVOKEDYNAMIC:
>  		seekerr = fseek(classfile, 4, SEEK_CUR);
>  		break;
>  	case CP_LONG:
> 


-- 
~Randy

  reply	other threads:[~2014-04-09 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31  3:47 [PATCH] Documentation/java.txt: add Java 7 support Jonathan Callen
2014-04-09 16:21 ` Randy Dunlap [this message]
2014-04-10  8:24   ` Jonathan Callen
2014-04-10 19:11     ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2012-12-13  3:06 Jonathan Callen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5345737E.4050008@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=jcallen@gentoo.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.