From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver' Date: Wed, 09 Apr 2014 20:27:39 +0400 Message-ID: <534574FB.7060901@cogentembedded.com> References: <201404091757.16574.sergei.shtylyov@cogentembedded.com> <534567BA.5030208@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f170.google.com ([209.85.217.170]:52806 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933983AbaDIQ1f (ORCPT ); Wed, 9 Apr 2014 12:27:35 -0400 Received: by mail-lb0-f170.google.com with SMTP id s7so1369901lbd.29 for ; Wed, 09 Apr 2014 09:27:33 -0700 (PDT) In-Reply-To: <534567BA.5030208@wwwdotorg.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Stephen Warren , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: Peter.Chen@freescale.com, stern@rowland.harvard.edu, thierry.reding@gmail.com, balbi@ti.com, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, magnus.damm@gmail.com Hello. On 04/09/2014 07:31 PM, Stephen Warren wrote: >> Return to the 'phy' field of 'struct usb_hcd' its historic name 'transceiver'. >> This is in preparation to adding the generic PHY support. > Surely if the correct term is transceiver, we should be adding generic > transceiver support not generic PHY support? To be honest, this rename > feels like churn, especially since the APIs and DT bindings all still > include the work phy so now everything will be inconsistent. How about 'usb_phy'? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 09 Apr 2014 16:27:39 +0000 Subject: Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver' Message-Id: <534574FB.7060901@cogentembedded.com> List-Id: References: <201404091757.16574.sergei.shtylyov@cogentembedded.com> <534567BA.5030208@wwwdotorg.org> In-Reply-To: <534567BA.5030208@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stephen Warren , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: Peter.Chen@freescale.com, stern@rowland.harvard.edu, thierry.reding@gmail.com, balbi@ti.com, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, magnus.damm@gmail.com Hello. On 04/09/2014 07:31 PM, Stephen Warren wrote: >> Return to the 'phy' field of 'struct usb_hcd' its historic name 'transceiver'. >> This is in preparation to adding the generic PHY support. > Surely if the correct term is transceiver, we should be adding generic > transceiver support not generic PHY support? To be honest, this rename > feels like churn, especially since the APIs and DT bindings all still > include the work phy so now everything will be inconsistent. How about 'usb_phy'? WBR, Sergei