All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 1/4] qapi: introduce PreallocMode and a new PreallocMode full.
Date: Wed, 09 Apr 2014 11:04:02 -0600	[thread overview]
Message-ID: <53457D82.8090109@redhat.com> (raw)
In-Reply-To: <2a4f67b31254a773cfae24ed750148c37e92e9cd.1397026795.git.hutao@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On 04/09/2014 01:12 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
> 
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  block/qcow2.c    |  8 ++++----
>  qapi-schema.json | 14 ++++++++++++++
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -4689,3 +4689,17 @@
>                'btn'     : 'InputBtnEvent',
>                'rel'     : 'InputMoveEvent',
>                'abs'     : 'InputMoveEvent' } }
> +
> +##
> +# @PreallocMode
> +#
> +# Preallocation mode of QEMU image file
> +#
> +# @off: no preallocation
> +# @metadata: preallocate only for metadata
> +# @full: preallocate all data, including metadata
> +#
> +# Since 2.0

You've missed 2.0.  This should be 2.1.  With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-04-09 17:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09  7:12 [Qemu-devel] [PATCH v8 0/4] qemu-img: add preallocation=full Hu Tao
2014-04-09  7:12 ` [Qemu-devel] [PATCH v8 1/4] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-04-09 17:04   ` Eric Blake [this message]
2014-04-09  7:12 ` [Qemu-devel] [PATCH v8 2/4] raw, qcow2: don't convert file size to sector size Hu Tao
2014-04-09  7:12 ` [Qemu-devel] [PATCH v8 3/4] raw-posix: Add full image preallocation option Hu Tao
2014-04-09  7:12 ` [Qemu-devel] [PATCH v8 4/4] qcow2: " Hu Tao
2014-05-06 12:19 ` [Qemu-devel] [PATCH v8 0/4] qemu-img: add preallocation=full Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53457D82.8090109@redhat.com \
    --to=eblake@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.