Re: [PATCH v4 7/7] HID: sony: Add blink support to the Sixaxis and DualShock 4 LEDs

[Frank Praznik <frank.praznik@gmail.com>]

On 4/9/2014 01:51, simon@mungewell.org wrote:
> Unfortunately I was unable to find the 'led chaining' code I mentioned. I
> guess it has been lost to the sands of time....
>
>>> 3rd Party Intec - Was unable to get any controlled blinking. As
>>> previously
>>> mentioned all leds flash (automatic, as if first plugged in) whenever
>>> all
>>> leds are turned off.
>>> I can control all leds in a static on/off mode, but can't set any
>>> blinking/timer behaviour
>> It sounds like this controller just doesn't implement all of the
>> behavior of the official controller.  I'm not sure how to fix it if it's
>> not obeying the instructions in valid output reports and I don't have
>> one to test personally.  Do the lights flash properly when the
>> controller is used with a PS3?
> I was able to patch the code so that I could turn all LEDs off my Intec
> controller, see attached. Tested this against the Intec and the SixAxis.

Thanks for taking care of this.  I'll add it to the v5 series when I 
send it in a couple of days.

>
> I was not able to make the LEDs flash in a controlled fashion, so you
> might be right about the controller not working properly - although my
> comments in python script suggests I did have something going.... must be
> missing a snippet of info.
>
>
> I also found that on the SixAxis, when I reported that I had to set 1st
> LED off before I could set it on.... this only applies when the controller
> was off and then plugged into USB. At this point the LEDs are slow
> flashing, and the 'brightness' reports as 1 (driver code only writes to
> device if value is changed).
>
> If the device was already on (LEDs flashing) then only the 1st LED is set
> on plug in, and I can turn LEDs off/on straight away.

Yeah, the controller overriding user settings and flashing by itself 
until the PS button is pushed is a particularly annoying aspect of the 
Sixaxis on USB and there is no perfect way to handle it.  I wish that I 
could just submit a report from within the driver the first time the PS 
button is pressed to restore the LED state, but that could mess with 
hidraw applications.  The next-best solution would probably be to not 
filter redundant LED state settings for Sixaxis controllers on USB.  
This way, userland can stop the flashing without having to toggle an LED 
on/off or off/on if they are already set to the desired state.  I'll 
make the change for v5.

Thanks again for all of the testing :)