From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: remove write-only assignments
Date: Wed, 09 Apr 2014 12:50:12 -0500 [thread overview]
Message-ID: <53458854.3030908@sgi.com> (raw)
In-Reply-To: <53457FAF.7060208@redhat.com>
On 04/09/14 12:13, Eric Sandeen wrote:
> There are many instances where variable assignments are made,
> but never read (or are re-assigned before they are read).
> The Clang static analyzer finds these.
>
> Here's a chunk of what I think are trivial removals of such
> assignments; other detections point to more serious problems
> (or are shared w/ kernel code so should probably be fixed there
> first).
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> These may be a bit tedious to review; perhaps graphical diff
> w/ more context would help in some cases?
>
This patch length is not so bad. Light reading with lunch. They all look
good to me.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-09 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 17:13 [PATCH] xfsprogs: remove write-only assignments Eric Sandeen
2014-04-09 17:50 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53458854.3030908@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.