From: Hongbo Zhang <hongbo.zhang@freescale.com>
To: David Laight <David.Laight@ACULAB.COM>,
"vkoul@infradead.org" <vkoul@infradead.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Cc: "scottwood@freescale.com" <scottwood@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"leo.li@freescale.com" <leo.li@freescale.com>
Subject: Re: [PATCH v3 2/8] DMA: Freescale: unify register access methods
Date: Thu, 10 Apr 2014 17:33:39 +0800 [thread overview]
Message-ID: <53466573.7050901@freescale.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6F4317@AcuExch.aculab.com>
On 04/10/2014 04:46 PM, David Laight wrote:
> From: hongbo.zhang@freescale.com
>> Methods of accessing DMA contorller registers are inconsistent, some registers
> ^^
Thanks.
sorry, that it a typo.
I would wait to see if there are other defects I have to correct, if yes
I can send a new iteration including this update, if no I would like to
know if the maintainer can do me the favor to correct it when merging
this patch, if still no, I will send a new iteration for this then.
>> are accessed by DMA_IN/OUT directly, while others are accessed by functions
>> get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it
>> is read by get_bcr but written by DMA_OUT.
>> This patch unifies the inconsistent methods, all registers are accessed by
>> get/set_* now.
> David
>
next prev parent reply other threads:[~2014-04-10 9:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 7:09 [PATCH v3 0/8] DMA: Freescale: driver cleanups and enhancements hongbo.zhang
2014-04-10 7:09 ` hongbo.zhang
2014-04-10 7:09 ` [PATCH v3 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG hongbo.zhang
2014-04-10 7:09 ` hongbo.zhang
2014-04-10 7:20 ` [PATCH v3 0/8] DMA: Freescale: driver cleanups and enhancements Hongbo Zhang
2014-04-10 7:20 ` Hongbo Zhang
2014-04-10 7:09 ` [PATCH v3 2/8] DMA: Freescale: unify register access methods hongbo.zhang
2014-04-10 7:09 ` hongbo.zhang
2014-04-10 8:46 ` David Laight
2014-04-10 8:46 ` David Laight
2014-04-10 9:33 ` Hongbo Zhang [this message]
2014-04-10 7:10 ` [PATCH v3 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 7:10 ` [PATCH v3 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 11:29 ` Andy Shevchenko
2014-04-10 11:29 ` Andy Shevchenko
2014-04-11 8:14 ` Hongbo Zhang
2014-04-11 8:14 ` Hongbo Zhang
2014-04-14 13:40 ` Andy Shevchenko
2014-04-14 13:40 ` Andy Shevchenko
2014-04-18 4:09 ` Hongbo Zhang
2014-04-18 4:09 ` Hongbo Zhang
2014-04-10 7:10 ` [PATCH v3 5/8] DMA: Freescale: move functions to avoid forward declarations hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 7:10 ` [PATCH v3 6/8] DMA: Freescale: change descriptor release process for supporting async_tx hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 11:56 ` Andy Shevchenko
2014-04-10 11:56 ` Andy Shevchenko
2014-04-11 8:00 ` Hongbo Zhang
2014-04-11 8:00 ` Hongbo Zhang
2014-04-11 8:33 ` Hongbo Zhang
2014-04-11 8:33 ` Hongbo Zhang
2014-04-14 13:41 ` Andy Shevchenko
2014-04-14 13:41 ` Andy Shevchenko
2014-04-10 7:10 ` [PATCH v3 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 7:10 ` [PATCH v3 8/8] DMA: Freescale: add suspend resume functions for DMA driver hongbo.zhang
2014-04-10 7:10 ` hongbo.zhang
2014-04-10 12:05 ` Andy Shevchenko
2014-04-10 12:05 ` Andy Shevchenko
2014-04-11 7:42 ` Hongbo Zhang
2014-04-11 7:42 ` Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53466573.7050901@freescale.com \
--to=hongbo.zhang@freescale.com \
--cc=David.Laight@ACULAB.COM \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=leo.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=vkoul@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.