From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/arm: traps: Add missing 0x in bad_trap Date: Thu, 10 Apr 2014 12:53:13 +0100 Message-ID: <53468629.10705@citrix.com> References: <1397130265-2389-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WYDXi-0002C2-Cs for xen-devel@lists.xenproject.org; Thu, 10 Apr 2014 11:53:18 +0000 In-Reply-To: <1397130265-2389-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On 10/04/14 12:44, Julien Grall wrote: > The syndrome value is printed in hexadecimal. Prefix it by 0x for less > confusion. > > Signed-off-by: Julien Grall Xen is trying to converge on '%#' rather than an explicit 0x. Also, it looks as if you want to do the same for IL ~Andrew > --- > xen/arch/arm/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 9eeed92..858abe5 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -1616,7 +1616,7 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs) > break; > default: > bad_trap: > - printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x Syndrome=%"PRIx32"\n", > + printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x Syndrome=0x%"PRIx32"\n", > hsr.bits, hsr.ec, hsr.len, hsr.iss); > do_unexpected_trap("Hypervisor", regs); > }