All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Carino, Mario" <Mario.Carino@AIG.com>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio on AIX - fallocate error
Date: Thu, 10 Apr 2014 08:00:30 -0600	[thread overview]
Message-ID: <5346A3FE.10106@kernel.dk> (raw)
In-Reply-To: <E2B4022DB0264A4B90C5F1B01B8E677D733225E0@LIVP3MMBX13.mail.aig.net>

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On 2014-04-09 20:52, Carino, Mario wrote:
> Hi.
> We're trying to run fio 2.1.7 on AIX 6 and we can't seem to eliminate these errors:
>
> fio: posix_fallocate fails: Invalid argument

This one you can ignore, or you can get rid of it by adding:

fallocate=none

to the job file.

> fio: pid=0, err=22/file:filesetup.c:418, func=invalidate_cache, error=Invalid argument

Fio should probably just ignore these flush-cache warnings and continue 
on, it's not really a fatal condition. I have attached a patch for you, 
can you apply that and give it a go?

> we always get one or the other. It doesn't matter too much what command we run,
> what options,  etc. We saw a web page which indicates that fio requires an
> Asynch IO package to be installed and running on AIX. Is that correct? We're
 > trying to find out if we have it installed on our test box.

You'd get a different error if that was your issue.

> (We're lowly non-root
 > DBA's so getting anything done requires a committee.)

Isn't that always the case with AIX? :-)

-- 
Jens Axboe


[-- Attachment #2: fio-make-cache-flush-just-warn.patch --]
[-- Type: text/x-patch, Size: 973 bytes --]

diff --git a/filesetup.c b/filesetup.c
index abea1e60b726..e1e48203f660 100644
--- a/filesetup.c
+++ b/filesetup.c
@@ -395,9 +395,6 @@ static int __file_invalidate_cache(struct thread_data *td, struct fio_file *f,
 	dprint(FD_IO, "invalidate cache %s: %llu/%llu\n", f->file_name, off,
 								len);
 
-	/*
-	 * FIXME: add blockdev flushing too
-	 */
 	if (f->mmap_ptr) {
 		ret = posix_madvise(f->mmap_ptr, f->mmap_sz, POSIX_MADV_DONTNEED);
 #ifdef FIO_MADV_FREE
@@ -419,6 +416,11 @@ static int __file_invalidate_cache(struct thread_data *td, struct fio_file *f,
 	} else if (f->filetype == FIO_TYPE_CHAR || f->filetype == FIO_TYPE_PIPE)
 		ret = 0;
 
+	if (ret) {
+		log_info("fio: cache flush failed: %s\n", strerror(errno));
+		ret = 0;
+	}
+
 	if (ret < 0) {
 		td_verror(td, errno, "invalidate_cache");
 		return 1;
@@ -427,7 +429,7 @@ static int __file_invalidate_cache(struct thread_data *td, struct fio_file *f,
 		return 1;
 	}
 
-	return ret;
+	return 0;
 
 }
 

  reply	other threads:[~2014-04-10 14:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  2:52 fio on AIX - fallocate error Carino, Mario
2014-04-10 14:00 ` Jens Axboe [this message]
2014-04-10 15:07   ` Jens Axboe
2014-04-10 15:30   ` Carino, Mario
2014-04-10 15:34     ` Jens Axboe
2014-04-10 15:56       ` Carino, Mario
2014-04-10 16:12         ` Jens Axboe
2014-04-10 16:22   ` Carino, Mario
2014-04-10 16:35     ` Jens Axboe
2014-04-10 16:44       ` Carino, Mario
2014-04-10 16:57         ` Jens Axboe
2014-04-10 16:59           ` Carino, Mario
2014-04-10 17:01             ` Jens Axboe
2014-04-10 17:26               ` Carino, Mario

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5346A3FE.10106@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Mario.Carino@AIG.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.