Re: [Qemu-devel] [PATCH v2 5/6] qemu-img: Specify backing file for commit

[Max Reitz <mreitz@redhat.com>]

On 08.04.2014 19:01, Eric Blake wrote:
> On 04/08/2014 06:50 AM, Max Reitz wrote:
>> Introduce a new parameter for qemu-img commit which may be used to
>> explicitly specify the backing file unto which an image should be
> s/unto/into/

I was wondering about that and asked someone about it (German as well, 
however), who said “unto” would be correct. And since you did not 
complain in v1… ;-)

I'll fix it.

>> committed if the backing chain has more than a single layer.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   qemu-img-cmds.hx |  4 ++--
>>   qemu-img.c       | 22 +++++++++++++++-------
>>   qemu-img.texi    |  8 +++++++-
>>   3 files changed, 24 insertions(+), 10 deletions(-)
>
>> +If the backing chain of the given image file @var{filename} has more than one
>> +layer, the backing file unto which the changes shall be committed may be
> s/unto/into/
> s/shall/will/

As long as there are no bugs, right. *g*

>> +specified as @var{backing_file} (which has to be part of @var{filename}'s
>> +backing chain). If @var{filename} is not specified, the immediate backing file
>> +of the top image (which is @var{filename}) will be used.
>> +
> With those changes,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>