From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 1/5] drm/exynos: remove dummy hdmiphy clock from hdmi driver Date: Thu, 10 Apr 2014 17:32:21 +0200 Message-ID: <5346B985.3000801@samsung.com> References: <1396458826-3051-1-git-send-email-rahul.sharma@samsung.com> <1396458826-3051-2-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:13561 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbaDJPc2 (ORCPT ); Thu, 10 Apr 2014 11:32:28 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3T0046WN5SS710@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 10 Apr 2014 16:32:17 +0100 (BST) In-reply-to: <1396458826-3051-2-git-send-email-rahul.sharma@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Rahul Sharma , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Cc: joshi@samsung.com Hi Rahul, On 02.04.2014 19:13, Rahul Sharma wrote: > From: Rahul Sharma > > Exynos drm hdmi driver used to get dummy hdmiphy clock to > control the PMU bit for hdmiphy. This clock is removed > during CCF migration. This should also be cleaned from > hdmi driver. > > Signed-off-by: Rahul Sharma > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 25bf65a..23abfa0 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -74,7 +74,6 @@ struct hdmi_resources { > struct clk *sclk_hdmi; > struct clk *sclk_pixel; > struct clk *sclk_hdmiphy; > - struct clk *hdmiphy; > struct clk *mout_hdmi; > struct regulator_bulk_data *regul_bulk; > int regul_count; > @@ -1854,7 +1853,6 @@ static void hdmi_poweron(struct exynos_drm_display *display) > if (regulator_bulk_enable(res->regul_count, res->regul_bulk)) > DRM_DEBUG_KMS("failed to enable regulator bulk\n"); > > - clk_prepare_enable(res->hdmiphy); > clk_prepare_enable(res->hdmi); > clk_prepare_enable(res->sclk_hdmi); > > @@ -1881,7 +1879,6 @@ static void hdmi_poweroff(struct exynos_drm_display *display) > > clk_disable_unprepare(res->sclk_hdmi); > clk_disable_unprepare(res->hdmi); > - clk_disable_unprepare(res->hdmiphy); > regulator_bulk_disable(res->regul_count, res->regul_bulk); > > pm_runtime_put_sync(hdata->dev); > @@ -1977,11 +1974,6 @@ static int hdmi_resources_init(struct hdmi_context *hdata) > DRM_ERROR("failed to get clock 'sclk_hdmiphy'\n"); > goto fail; > } > - res->hdmiphy = devm_clk_get(dev, "hdmiphy"); > - if (IS_ERR(res->hdmiphy)) { > - DRM_ERROR("failed to get clock 'hdmiphy'\n"); > - goto fail; > - } > res->mout_hdmi = devm_clk_get(dev, "mout_hdmi"); > if (IS_ERR(res->mout_hdmi)) { > DRM_ERROR("failed to get clock 'mout_hdmi'\n"); > This patch makes the series non-bisectable. If you remove handling of this dummy clock until you add proper support for PHY isolation setting, then at this point you end up with non-working code. You should first provide new infrastructure in parallel to existing one, then move all users to new one and only then drop the old one. Best regards, Tomasz