From: Chris Mason <clm@fb.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Cc: <fengguang.wu@intel.com>, <kbuild-all@01.org>
Subject: Re: [PATCH v4 2/2] Btrfs: scrub raid56 stripes in the right way
Date: Thu, 10 Apr 2014 19:36:11 -0400 [thread overview]
Message-ID: <53472AEB.7030004@fb.com> (raw)
In-Reply-To: <1396955932-4547-1-git-send-email-wangsl.fnst@cn.fujitsu.com>
On 04/08/2014 07:18 AM, Wang Shilong wrote:
> Steps to reproduce:
> # mkfs.btrfs -f /dev/sda[8-11] -m raid5 -d raid5
> # mount /dev/sda8 /mnt
> # btrfs scrub start -BR /mnt
> # echo $? <--unverified errors make return value be 3
>
> This is because we don't setup right mapping between physical
> and logical address for raid56, which makes checksum mismatch.
> But we will find everthing is fine later when rechecking using
> btrfs_map_block().
>
> This patch fixed the problem by settuping right mappings and
> we only verify data stripes' checksums.
>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> ---
> v3->v4: fix compile warnings on avr32 platform.(reported by 0-day LKP)
Can you please send this as an incremental? I'd rather not rebase the
integration branch right now.
Thanks!
-chris
prev parent reply other threads:[~2014-04-10 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 11:18 [PATCH v4 2/2] Btrfs: scrub raid56 stripes in the right way Wang Shilong
2014-04-10 23:36 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53472AEB.7030004@fb.com \
--to=clm@fb.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.