From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/3] x86/mem_access: Make the mem_access ops
 generic
Date: Fri, 11 Apr 2014 10:35:37 +0100
Message-ID: <5347B769.5040106@citrix.com>
References: <1397188179-14606-1-git-send-email-aravindp@cisco.com>
	<1397188179-14606-2-git-send-email-aravindp@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1WYXs5-0001OA-NE
	for xen-devel@lists.xenproject.org; Fri, 11 Apr 2014 09:35:41 +0000
In-Reply-To: <1397188179-14606-2-git-send-email-aravindp@cisco.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Aravindh Puthiyaparambil <aravindp@cisco.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 11/04/14 04:49, Aravindh Puthiyaparambil wrote:
> --- a/xen/arch/x86/mm/mem_access.c
> +++ b/xen/arch/x86/mm/mem_access.c
> @@ -21,31 +21,98 @@
>   */
>  
>  
> +#include <xen/sched.h>
> +#include <xen/guest_access.h>
> +#include <xen/hypercall.h>
>  #include <asm/p2m.h>
>  #include <asm/mem_event.h>
> +#include <xsm/xsm.h>
>  
>  
> -int mem_access_memop(struct domain *d, xen_mem_event_op_t *meo)
> +#define ACCESS_op_mask  0xff
> +
> +int mem_access_memop(XEN_GUEST_HANDLE_PARAM(void) arg, unsigned long start_iter)
>  {
> -    int rc;
> +    long rc;

int function and long rc? The function wants promoting to long.

~Andrew