All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] net: sun4i-emac: add promiscuous support
Date: Fri, 11 Apr 2014 11:55:50 +0200	[thread overview]
Message-ID: <5347BC26.4070907@denx.de> (raw)
In-Reply-To: <1397209577-24443-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org>

On 11.04.2014 11:46, Marc Zyngier wrote:
> The sun4i-emac driver is rather primitive, and doesn't support
> promiscuous mode. This makes usage such as bridging impossible,
> which is a shame on virtualization capable HW such as the
> Allwinner A20.
>
> The fix is fairly simple: move the RX setup code to the ndo_set_rx_mode
> vector, and add the required HW configuration when IFF_PROMISC is passed
> by the core code.
>
> This has been tested on a generic A20 box running a few virtual
> machines hanging off a bridge with the EMAC chip as the link to the
> outside world.
>
> Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>

Looks good, so:

Acked-by: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>

Thanks,
Stefan

  parent reply	other threads:[~2014-04-11  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11  9:46 [PATCH] net: sun4i-emac: add promiscuous support Marc Zyngier
     [not found] ` <1397209577-24443-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org>
2014-04-11  9:55   ` Stefan Roese [this message]
2014-04-12  6:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5347BC26.4070907@denx.de \
    --to=sr-ynqeqjnshbs@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.