On 11/04/14 11:28, Jan Beulich wrote:
> set_p2m_entry() can fail without there being a bug in the code - crash
> the domain rather than the host in that case.

It would be useful to indicate which conditions.

>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Irrespective of the conditions causing a failed p2m update, this is
certainly a good change

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/mm/hap/nested_hap.c
> +++ b/xen/arch/x86/mm/hap/nested_hap.c
> @@ -133,7 +133,7 @@ nestedhap_fix_p2m(struct vcpu *v, struct
>          gdprintk(XENLOG_ERR,
>  		"failed to set entry for %#"PRIx64" -> %#"PRIx64"\n",
>  		L2_gpa, L0_gpa);
> -        BUG();
> +        domain_crash(p2m->domain);
>      }
>  }
>  
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel