From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYagn-0007EI-Gz for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:36:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYagj-0008ML-0v for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:36:13 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:51288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYagi-0008ME-Np for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:36:08 -0400 Message-ID: <5347E1B2.6000606@huawei.com> Date: Fri, 11 Apr 2014 14:36:02 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1396555000-8205-1-git-send-email-rth@twiddle.net> <1396555000-8205-27-git-send-email-rth@twiddle.net> In-Reply-To: <1396555000-8205-27-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 26/26] tcg-aarch64: Use tcg_out_mov in preference to tcg_out_movr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: claudio.fontana@gmail.com On 03.04.2014 21:56, Richard Henderson wrote: > It's the more canonical interface. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 58597e7..ab4cd25 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -951,9 +951,7 @@ static inline void tcg_out_addsub2(TCGContext *s, int ext, TCGReg rl, > } > tcg_out_insn_3503(s, insn, ext, rh, ah, bh); > > - if (rl != orig_rl) { > - tcg_out_movr(s, ext, orig_rl, rl); > - } > + tcg_out_mov(s, ext, orig_rl, rl); > } > > #ifdef CONFIG_SOFTMMU > @@ -997,15 +995,15 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *lb) > > reloc_pc19(lb->label_ptr[0], (intptr_t)s->code_ptr); > > - tcg_out_movr(s, TCG_TYPE_I64, TCG_REG_X0, TCG_AREG0); > - tcg_out_movr(s, TARGET_LONG_BITS == 64, TCG_REG_X1, lb->addrlo_reg); > + tcg_out_mov(s, TCG_TYPE_I64, TCG_REG_X0, TCG_AREG0); > + tcg_out_mov(s, TARGET_LONG_BITS == 64, TCG_REG_X1, lb->addrlo_reg); > tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_X2, lb->mem_index); > tcg_out_adr(s, TCG_REG_X3, (intptr_t)lb->raddr); > tcg_out_call(s, (intptr_t)qemu_ld_helpers[opc & ~MO_SIGN]); > if (opc & MO_SIGN) { > tcg_out_sxt(s, TCG_TYPE_I64, size, lb->datalo_reg, TCG_REG_X0); > } else { > - tcg_out_movr(s, TCG_TYPE_I64, lb->datalo_reg, TCG_REG_X0); > + tcg_out_mov(s, size == MO_64, lb->datalo_reg, TCG_REG_X0); > } > > tcg_out_goto(s, (intptr_t)lb->raddr); > @@ -1018,9 +1016,9 @@ static void tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *lb) > > reloc_pc19(lb->label_ptr[0], (intptr_t)s->code_ptr); > > - tcg_out_movr(s, TCG_TYPE_I64, TCG_REG_X0, TCG_AREG0); > - tcg_out_movr(s, TARGET_LONG_BITS == 64, TCG_REG_X1, lb->addrlo_reg); > - tcg_out_movr(s, size == MO_64, TCG_REG_X2, lb->datalo_reg); > + tcg_out_mov(s, TCG_TYPE_I64, TCG_REG_X0, TCG_AREG0); > + tcg_out_mov(s, TARGET_LONG_BITS == 64, TCG_REG_X1, lb->addrlo_reg); > + tcg_out_mov(s, size == MO_64, TCG_REG_X2, lb->datalo_reg); > tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_X3, lb->mem_index); > tcg_out_adr(s, TCG_REG_X4, (intptr_t)lb->raddr); > tcg_out_call(s, (intptr_t)qemu_st_helpers[opc]); > Reviewed-by: Claudio Fontana