From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46385)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WYdal-0004Ei-0w
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 11:42:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WYdag-0004gz-Qf
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 11:42:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WYdag-0004gV-4B
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 11:42:06 -0400
Message-ID: <53480D48.901@redhat.com>
Date: Fri, 11 Apr 2014 09:42:00 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <20140402151558.8123.58942.stgit@fimbulvetr.bsc.es>
	<20140402151605.8123.89663.stgit@fimbulvetr.bsc.es>
In-Reply-To: <20140402151605.8123.89663.stgit@fimbulvetr.bsc.es>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="vr2PUD6kbeqfoDT72Fb976XFMEHORwC4r"
Subject: Re: [Qemu-devel] [PATCH v8 1/4] qapi: [trivial] Break long command
	lines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@irqsave.net>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vr2PUD6kbeqfoDT72Fb976XFMEHORwC4r
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/02/2014 09:16 AM, Llu=C3=ADs Vilanova wrote:
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile       |   24 ++++++++++++++++++------
>  tests/Makefile |   20 ++++++++++++++++----
>  2 files changed, 34 insertions(+), 10 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> +	$(call quiet-command, PYTHONPATH=3D$(SRC_PATH)/scripts \
> +		$(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \
> +		<$^ \
> +		>$*.test.out \
> +		2>$*.test.err; \

I probably would have merged these three lines, but that's cosmetic and
doesn't affect my review.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--vr2PUD6kbeqfoDT72Fb976XFMEHORwC4r
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTSA1IAAoJEKeha0olJ0NqGg0IAJ3RWJtTa3TDF95D6rgup2Rr
lTT1Jeo+nfD9uI0OxVoW0cTwMeImgOezyF/Xc/bs1BZzkKBa1n7rawr52YG7gV3G
9x3ajCX0iA7mz4bWP4IhBP6iNQYUekfB/DdFWB+iy/2SLS7wmZQA/9QqARE2Dj6f
/gkCqhQtv0AUcj/RCZvKbrEAOrGYi5H+T1hQ1cAA5yojWoLMnVh5GHeZvO6dL2Kf
jCc1k/95Kg+mjcsEtAfrk6gQhxdiaPV8bIiBkgOmvSxbm+C1gctpKx9aF9p+0qMf
m7RuVKEEXR1RhJClB8gmfVOpg0k0opB/bBVPElOsq2JWsJskqc9Ku5q35YZcv6I=
=1X4G
-----END PGP SIGNATURE-----

--vr2PUD6kbeqfoDT72Fb976XFMEHORwC4r--