From: Tomasz Figa <t.figa@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>, kgene.kim@samsung.com
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
Date: Fri, 11 Apr 2014 18:00:53 +0200 [thread overview]
Message-ID: <534811B5.10906@samsung.com> (raw)
In-Reply-To: <1397226211-29775-1-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester,
On 11.04.2014 16:23, Sylwester Nawrocki wrote:
> Exynos4212/4412 has different clock for the PL330 MDMA, ensure
> the clock is properly assigned for these newer SoCs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index c4a9306..19589c6 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -243,4 +243,10 @@
> clock-names = "biu", "ciu";
> status = "disabled";
> };
> +
> + amba {
> + mdma@12850000 {
> + clocks = <&clock CLK_MDMA2>;
> + };
> + };
> };
>
Since the ID for CLK_MDMA2 was added mistakenly, instead of reusing
CLK_MDMA and it was not used by any device tree files anyway, I believe
the better fix would be to simply change the clock definition in Exynos
4 clock driver to use CLK_MDMA for both SoC families.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
Date: Fri, 11 Apr 2014 18:00:53 +0200 [thread overview]
Message-ID: <534811B5.10906@samsung.com> (raw)
In-Reply-To: <1397226211-29775-1-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester,
On 11.04.2014 16:23, Sylwester Nawrocki wrote:
> Exynos4212/4412 has different clock for the PL330 MDMA, ensure
> the clock is properly assigned for these newer SoCs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index c4a9306..19589c6 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -243,4 +243,10 @@
> clock-names = "biu", "ciu";
> status = "disabled";
> };
> +
> + amba {
> + mdma at 12850000 {
> + clocks = <&clock CLK_MDMA2>;
> + };
> + };
> };
>
Since the ID for CLK_MDMA2 was added mistakenly, instead of reusing
CLK_MDMA and it was not used by any device tree files anyway, I believe
the better fix would be to simply change the clock definition in Exynos
4 clock driver to use CLK_MDMA for both SoC families.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-11 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 14:23 [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12 Sylwester Nawrocki
2014-04-11 14:23 ` Sylwester Nawrocki
2014-04-11 16:00 ` Tomasz Figa [this message]
2014-04-11 16:00 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534811B5.10906@samsung.com \
--to=t.figa@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.