* [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
@ 2014-04-11 14:23 ` Sylwester Nawrocki
0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2014-04-11 14:23 UTC (permalink / raw)
To: kgene.kim; +Cc: linux-samsung-soc, linux-arm-kernel, Sylwester Nawrocki
Exynos4212/4412 has different clock for the PL330 MDMA, ensure
the clock is properly assigned for these newer SoCs.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index c4a9306..19589c6 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -243,4 +243,10 @@
clock-names = "biu", "ciu";
status = "disabled";
};
+
+ amba {
+ mdma@12850000 {
+ clocks = <&clock CLK_MDMA2>;
+ };
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
@ 2014-04-11 14:23 ` Sylwester Nawrocki
0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2014-04-11 14:23 UTC (permalink / raw)
To: linux-arm-kernel
Exynos4212/4412 has different clock for the PL330 MDMA, ensure
the clock is properly assigned for these newer SoCs.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index c4a9306..19589c6 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -243,4 +243,10 @@
clock-names = "biu", "ciu";
status = "disabled";
};
+
+ amba {
+ mdma at 12850000 {
+ clocks = <&clock CLK_MDMA2>;
+ };
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
2014-04-11 14:23 ` Sylwester Nawrocki
@ 2014-04-11 16:00 ` Tomasz Figa
-1 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-04-11 16:00 UTC (permalink / raw)
To: Sylwester Nawrocki, kgene.kim; +Cc: linux-samsung-soc, linux-arm-kernel
Hi Sylwester,
On 11.04.2014 16:23, Sylwester Nawrocki wrote:
> Exynos4212/4412 has different clock for the PL330 MDMA, ensure
> the clock is properly assigned for these newer SoCs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index c4a9306..19589c6 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -243,4 +243,10 @@
> clock-names = "biu", "ciu";
> status = "disabled";
> };
> +
> + amba {
> + mdma@12850000 {
> + clocks = <&clock CLK_MDMA2>;
> + };
> + };
> };
>
Since the ID for CLK_MDMA2 was added mistakenly, instead of reusing
CLK_MDMA and it was not used by any device tree files anyway, I believe
the better fix would be to simply change the clock definition in Exynos
4 clock driver to use CLK_MDMA for both SoC families.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12
@ 2014-04-11 16:00 ` Tomasz Figa
0 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-04-11 16:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sylwester,
On 11.04.2014 16:23, Sylwester Nawrocki wrote:
> Exynos4212/4412 has different clock for the PL330 MDMA, ensure
> the clock is properly assigned for these newer SoCs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index c4a9306..19589c6 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -243,4 +243,10 @@
> clock-names = "biu", "ciu";
> status = "disabled";
> };
> +
> + amba {
> + mdma at 12850000 {
> + clocks = <&clock CLK_MDMA2>;
> + };
> + };
> };
>
Since the ID for CLK_MDMA2 was added mistakenly, instead of reusing
CLK_MDMA and it was not used by any device tree files anyway, I believe
the better fix would be to simply change the clock definition in Exynos
4 clock driver to use CLK_MDMA for both SoC families.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-11 16:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 14:23 [PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12 Sylwester Nawrocki
2014-04-11 14:23 ` Sylwester Nawrocki
2014-04-11 16:00 ` Tomasz Figa
2014-04-11 16:00 ` Tomasz Figa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.