From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYeHt-0001Ii-1Z for qemu-devel@nongnu.org; Fri, 11 Apr 2014 12:26:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYeHj-0002MY-Lm for qemu-devel@nongnu.org; Fri, 11 Apr 2014 12:26:44 -0400 Message-ID: <534817B8.8060501@suse.de> Date: Fri, 11 Apr 2014 18:26:32 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1394720011-2482-1-git-send-email-tommusta@gmail.com> In-Reply-To: <1394720011-2482-1-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 0/6] Refactor AES Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Richard Henderson On 13.03.14 15:13, Tom Musta wrote: > This patch series addresses concerns raised by Richard Henderson regarding redundant > copies of Advanced Encryption Standard (AES) data and code (see > http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). > > The patches declare commonly used AES tables in the include/qemu/aes.h header file > and define the tables in util/aes.c, thus eliminating redundant copies. > > Minor refactorization of the i386 and ARM instruction models are made to utilize > this common support. The newly added PowerPC instructions are completely > rewritten and look much more like the i386 equivalents; a substantial amount of > code is eliminated. > > V2: updated patch 05/06 per Richard Henderson's review (const pointer to const) Looks good to me. Which queue should this go through? IMHO Richard would be the perfect person to get this through one of his. Alex