From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYemE-0001fa-Og for qemu-devel@nongnu.org; Fri, 11 Apr 2014 12:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYem9-0004JT-FJ for qemu-devel@nongnu.org; Fri, 11 Apr 2014 12:58:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37571 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYem6-0004J8-GK for qemu-devel@nongnu.org; Fri, 11 Apr 2014 12:58:01 -0400 Message-ID: <53481F15.7010902@suse.de> Date: Fri, 11 Apr 2014 18:57:57 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <2f8f007ce2152ac3b65f0811199662799c509225.1397155389.git.crobinso@redhat.com> In-Reply-To: <2f8f007ce2152ac3b65f0811199662799c509225.1397155389.git.crobinso@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org, Peter Maydell Cc: m.gibula@beyond.pl, Stefan Hajnoczi , Marcel Apfelbaum Am 10.04.2014 20:47, schrieb Cole Robinson: > Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of > 'opaque' for link properties, but missed updating this call site. > Reproducer: >=20 > ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server & > ./scripts/qmp/qmp-shell ./qmp.sock > (QEMU) qom-list path=3D//machine/i440fx/pci.0/child[2] I would much prefer if we could give the path as just path=3D/machine/i440fx/pci.0/child[2] (without double slash). Peter can you improve when applying? >=20 > Reported-by: Marcin Gibu=C5=82a > Signed-off-by: Cole Robinson > --- > qom/object.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Andreas F=C3=A4rber I would like to remark that specifically for regression-testing link<> properties I had extended qom-test, and it succeeds currently. So Cole, if you have any suggestion on how to extend it to catch this regression that would be welcome. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg