From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYf0a-0006u7-Nv for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYf0V-0000kP-8z for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:12:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37820 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYf0V-0000kE-32 for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:12:51 -0400 Message-ID: <53482291.9000505@suse.de> Date: Fri, 11 Apr 2014 19:12:49 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <2f8f007ce2152ac3b65f0811199662799c509225.1397155389.git.crobinso@redhat.com> <53481F15.7010902@suse.de> <534820ED.9080209@redhat.com> In-Reply-To: <534820ED.9080209@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org Cc: Peter Maydell , m.gibula@beyond.pl, Stefan Hajnoczi , Marcel Apfelbaum Am 11.04.2014 19:05, schrieb Cole Robinson: > On 04/11/2014 12:57 PM, Andreas F=C3=A4rber wrote: >> Am 10.04.2014 20:47, schrieb Cole Robinson: >>> Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of >>> 'opaque' for link properties, but missed updating this call site. >>> Reproducer: >>> >>> ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server & >>> ./scripts/qmp/qmp-shell ./qmp.sock >>> (QEMU) qom-list path=3D//machine/i440fx/pci.0/child[2] >> >> I would much prefer if we could give the path as just >> path=3D/machine/i440fx/pci.0/child[2] (without double slash). Peter ca= n >> you improve when applying? >> >>> >>> Reported-by: Marcin Gibu=C5=82a >>> Signed-off-by: Cole Robinson >>> --- >>> qom/object.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> Reviewed-by: Andreas F=C3=A4rber >> >> I would like to remark that specifically for regression-testing link<> >> properties I had extended qom-test, and it succeeds currently. So Cole= , >> if you have any suggestion on how to extend it to catch this regressio= n >> that would be welcome. >> >=20 > I haven't looked closely at tests/, I see *qmp*.c files, but is there > infrastructure for running qmp commands? If so we could turn the above > reproducer into a test case. Please see the mentioned tests/qom-test.c, it is already doing qom-list + qom-get for all properties - therefore wondering why we didn't catch th= is. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg